2020-03-28 16:46:00

by George Spelvin

[permalink] [raw]
Subject: [RFC PATCH v1 48/50] arch/arm/kernel/process.c: Use get_random_max32() for sigpage_addr()

Which is faster and less biased than get_random_int() % range

Signed-off-by: George Spelvin <[email protected]>
Cc: Nathan Lynch <[email protected]>
Cc: Dmitry Safonov <[email protected]>
Cc: Russell King <[email protected]>
Cc: [email protected]
---
arch/arm/kernel/process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 46e478fb5ea20..9f2556be33505 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -391,7 +391,7 @@ static unsigned long sigpage_addr(const struct mm_struct *mm,

slots = ((last - first) >> PAGE_SHIFT) + 1;

- offset = get_random_int() % slots;
+ offset = get_random_max32(slots);

addr = first + (offset << PAGE_SHIFT);

--
2.26.0