2020-03-29 22:55:20

by Vasily Khoruzhick

Subject: [PATCH] drm/bridge: anx6345: set correct BPC for display_info of connector

Some drivers (e.g. sun4i-drm) need this info to decide whether they
need to enable dithering. Currently driver reports what panel supports
and if panel supports 8 we don't get dithering enabled.

Hardcode BPC to 6 for now since that's the only BPC
that driver supports.

Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
Signed-off-by: Vasily Khoruzhick <[email protected]>
---
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
index d7cb10c599a3..ea5de9395662 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -494,6 +494,9 @@ static int anx6345_get_modes(struct drm_connector *connector)

num_modes += drm_add_edid_modes(connector, anx6345->edid);

+ /* Driver currently supports only 6bpc */
+ connector->display_info.bpc = 6;
+
unlock:
if (power_off)
anx6345_poweroff(anx6345);
--
2.25.0

2020-03-29 23:36:37

by Jernej Skrabec

Subject: Re: [PATCH] drm/bridge: anx6345: set correct BPC for display_info of connector

Hi!

Dne ponedeljek, 30. marec 2020 ob 00:22:53 CEST je Vasily Khoruzhick
napisal(a):
> Some drivers (e.g. sun4i-drm) need this info to decide whether they
> need to enable dithering. Currently driver reports what panel supports
> and if panel supports 8 we don't get dithering enabled.
>
> Hardcode BPC to 6 for now since that's the only BPC
> that driver supports.

Acked-by: Jernej Skrabec <[email protected]>

Best regards,
Jernej

>
> Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
> Signed-off-by: Vasily Khoruzhick <[email protected]>
> ---
> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c index
> d7cb10c599a3..ea5de9395662 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> @@ -494,6 +494,9 @@ static int anx6345_get_modes(struct drm_connector
> *connector)
>
> num_modes += drm_add_edid_modes(connector, anx6345->edid);
>
> + /* Driver currently supports only 6bpc */
> + connector->display_info.bpc = 6;
> +
> unlock:
> if (power_off)
> anx6345_poweroff(anx6345);

2020-04-15 21:48:40

by Jernej Skrabec

Subject: Re: drm/bridge: anx6345: set correct BPC for display_info of connector

Dne ponedeljek, 30. marec 2020 ob 00:22:53 CEST je Vasily Khoruzhick
napisal(a):
> Some drivers (e.g. sun4i-drm) need this info to decide whether they
> need to enable dithering. Currently driver reports what panel supports
> and if panel supports 8 we don't get dithering enabled.
>
> Hardcode BPC to 6 for now since that's the only BPC
> that driver supports.
>
> Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
> Signed-off-by: Vasily Khoruzhick <[email protected]>

Applied to drm-misc-fixes. Thanks!

Best regards,
Jernej