2020-03-13 16:59:07

by Johan Jonker

[permalink] [raw]
Subject: [PATCH] dt-bindings: leds: common: fix example for gpio-leds

The preferred form for gpio-leds compatible subnodes is:
^led-[0-9a-f]$
Fix example by changing led0 and led1 to led-0 and led-1.

Signed-off-by: Johan Jonker <[email protected]>
---
Documentation/devicetree/bindings/leds/common.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index c60b994fe..4c270fde4 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -167,13 +167,13 @@ examples:
led-controller {
compatible = "gpio-leds";

- led0 {
+ led-0 {
function = LED_FUNCTION_STATUS;
linux,default-trigger = "heartbeat";
gpios = <&gpio0 0 GPIO_ACTIVE_HIGH>;
};

- led1 {
+ led-1 {
function = LED_FUNCTION_USB;
gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>;
trigger-sources = <&ohci_port1>, <&ehci_port1>;
--
2.11.0


2020-03-21 15:47:24

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: leds: common: fix example for gpio-leds

On Fri 2020-03-13 17:57:00, Johan Jonker wrote:
> The preferred form for gpio-leds compatible subnodes is:
> ^led-[0-9a-f]$
> Fix example by changing led0 and led1 to led-0 and led-1.
>
> Signed-off-by: Johan Jonker <[email protected]>

Acked-by: Pavel Machek <[email protected]>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachments:
(No filename) (425.00 B)
 signature.asc (201.00 B)
 Download all attachments

2020-03-30 18:45:45

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: leds: common: fix example for gpio-leds

On Fri, 13 Mar 2020 17:57:00 +0100, Johan Jonker wrote:
> The preferred form for gpio-leds compatible subnodes is:
> ^led-[0-9a-f]$
> Fix example by changing led0 and led1 to led-0 and led-1.
>
> Signed-off-by: Johan Jonker <[email protected]>
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Applied, thanks.

Rob