2020-04-03 17:09:22

by Alyssa Ross

[permalink] [raw]
Subject: [PATCH] Documentation: sysrq: fix RST formatting

"On x86" and "On SPARC" are now definition list terms, like
"On PowerPC", "On other", and "On all".

The Credits list is now a bulleted list, like lots of Credits lists in
other files. This prevents the list from becoming a single long,
unpunctuated sentence in the generated documentation.

I also did a couple of other tiny readability improvements to the
"How do I use the magic SysRq key?" section while I was there.

Signed-off-by: Alyssa Ross <[email protected]>
---
Documentation/admin-guide/sysrq.rst | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/Documentation/admin-guide/sysrq.rst b/Documentation/admin-guide/sysrq.rst
index 72b2cfb066f4..a46209f4636c 100644
--- a/Documentation/admin-guide/sysrq.rst
+++ b/Documentation/admin-guide/sysrq.rst
@@ -48,9 +48,10 @@ always allowed (by a user with admin privileges).
How do I use the magic SysRq key?
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

-On x86 - You press the key combo :kbd:`ALT-SysRq-<command key>`.
+On x86
+ You press the key combo :kbd:`ALT-SysRq-<command key>`.

-.. note::
+ .. note::
Some
keyboards may not have a key labeled 'SysRq'. The 'SysRq' key is
also known as the 'Print Screen' key. Also some keyboards cannot
@@ -58,14 +59,15 @@ On x86 - You press the key combo :kbd:`ALT-SysRq-<command key>`.
have better luck with press :kbd:`Alt`, press :kbd:`SysRq`,
release :kbd:`SysRq`, press :kbd:`<command key>`, release everything.

-On SPARC - You press :kbd:`ALT-STOP-<command key>`, I believe.
+On SPARC
+ You press :kbd:`ALT-STOP-<command key>`, I believe.

On the serial console (PC style standard serial ports only)
You send a ``BREAK``, then within 5 seconds a command key. Sending
``BREAK`` twice is interpreted as a normal BREAK.

On PowerPC
- Press :kbd:`ALT - Print Screen` (or :kbd:`F13`) - :kbd:`<command key>`,
+ Press :kbd:`ALT - Print Screen` (or :kbd:`F13`) - :kbd:`<command key>`.
:kbd:`Print Screen` (or :kbd:`F13`) - :kbd:`<command key>` may suffice.

On other
@@ -73,7 +75,7 @@ On other
let me know so I can add them to this section.

On all
- write a character to /proc/sysrq-trigger. e.g.::
+ Write a character to /proc/sysrq-trigger. e.g.::

echo t > /proc/sysrq-trigger

@@ -282,7 +284,7 @@ Just ask them on the linux-kernel mailing list:
Credits
~~~~~~~

-Written by Mydraal <[email protected]>
-Updated by Adam Sulmicki <[email protected]>
-Updated by Jeremy M. Dolan <[email protected]> 2001/01/28 10:15:59
-Added to by Crutcher Dunnavant <[email protected]>
+- Written by Mydraal <[email protected]>
+- Updated by Adam Sulmicki <[email protected]>
+- Updated by Jeremy M. Dolan <[email protected]> 2001/01/28 10:15:59
+- Added to by Crutcher Dunnavant <[email protected]>
--
2.24.1


2020-04-07 19:34:15

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] Documentation: sysrq: fix RST formatting

On Fri, 3 Apr 2020 17:07:01 +0000
Alyssa Ross <[email protected]> wrote:

> "On x86" and "On SPARC" are now definition list terms, like
> "On PowerPC", "On other", and "On all".
>
> The Credits list is now a bulleted list, like lots of Credits lists in
> other files. This prevents the list from becoming a single long,
> unpunctuated sentence in the generated documentation.
>
> I also did a couple of other tiny readability improvements to the
> "How do I use the magic SysRq key?" section while I was there.
>
> Signed-off-by: Alyssa Ross <[email protected]>

Applied, thanks.

jon