2020-03-23 06:12:35

by afzal mohammed

Subject: [PATCH] clocksource/drivers/timer-vf-pit: Fix build error

Recently all usages of setup_irq() was replaced by request_irq(). The
replacement in timer-vf-pit.c missed closing parentheses resulting in
build error (vf610m4_defconfig). Fix it.

Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()")
Reported-by: kbuild test robot <[email protected]>
Signed-off-by: afzal mohammed <[email protected]>
---
drivers/clocksource/timer-vf-pit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-vf-pit.c b/drivers/clocksource/timer-vf-pit.c
index 7ad4a8b008c2..1a86a4e7e344 100644
--- a/drivers/clocksource/timer-vf-pit.c
+++ b/drivers/clocksource/timer-vf-pit.c
@@ -129,7 +129,7 @@ static int __init pit_clockevent_init(unsigned long rate, int irq)
__raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);

BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
- "VF pit timer", &clockevent_pit);
+ "VF pit timer", &clockevent_pit));

clockevent_pit.cpumask = cpumask_of(0);
clockevent_pit.irq = irq;
--
2.25.1

2020-03-23 10:04:10

by Daniel Lezcano

Subject: Re: [PATCH] clocksource/drivers/timer-vf-pit: Fix build error

On 23/03/2020 07:11, afzal mohammed wrote:
> Recently all usages of setup_irq() was replaced by request_irq(). The
> replacement in timer-vf-pit.c missed closing parentheses resulting in
> build error (vf610m4_defconfig). Fix it.
>
> Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()")
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: afzal mohammed <[email protected]>
> ---
> drivers/clocksource/timer-vf-pit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-vf-pit.c b/drivers/clocksource/timer-vf-pit.c
> index 7ad4a8b008c2..1a86a4e7e344 100644
> --- a/drivers/clocksource/timer-vf-pit.c
> +++ b/drivers/clocksource/timer-vf-pit.c
> @@ -129,7 +129,7 @@ static int __init pit_clockevent_init(unsigned long rate, int irq)
> __raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);
>
> BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
> - "VF pit timer", &clockevent_pit);
> + "VF pit timer", &clockevent_pit));

Applied


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2020-03-31 11:42:45

by Daniel Lezcano

Subject: Re: [PATCH] clocksource/drivers/timer-vf-pit: Fix build error

Hi Thomas,

I was about to send a PR with the revert and this patch. As you picked
up the revert, do you mind to pick also this one?

Thanks

-- Daniel


On 23/03/2020 07:11, afzal mohammed wrote:
> Recently all usages of setup_irq() was replaced by request_irq().
> The replacement in timer-vf-pit.c missed closing parentheses
> resulting in build error (vf610m4_defconfig). Fix it.
>
> Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by
> request_irq()") Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: afzal mohammed <[email protected]> ---
> drivers/clocksource/timer-vf-pit.c | 2 +- 1 file changed, 1
> insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-vf-pit.c
> b/drivers/clocksource/timer-vf-pit.c index
> 7ad4a8b008c2..1a86a4e7e344 100644 ---
> a/drivers/clocksource/timer-vf-pit.c +++
> b/drivers/clocksource/timer-vf-pit.c @@ -129,7 +129,7 @@ static int
> __init pit_clockevent_init(unsigned long rate, int irq)
> __raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);
>
> BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER |
> IRQF_IRQPOLL, - "VF pit timer", &clockevent_pit); + "VF
> pit timer", &clockevent_pit));
>
> clockevent_pit.cpumask = cpumask_of(0); clockevent_pit.irq = irq;
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2020-04-05 05:40:20

by afzal mohammed

Subject: Re: [PATCH] clocksource/drivers/timer-vf-pit: Fix build error

Hi Daniel, Thomas,

On Tue, Mar 31, 2020 at 01:40:36PM +0200, Daniel Lezcano wrote:

> Hi Thomas,
>
> I was about to send a PR with the revert and this patch. As you picked
> up the revert, do you mind to pick also this one?

Mainline is broken w/o this change for ARM vf610m4_defconfig, Stephen
Rothwell also reported it today, please do the needful so as to let it
reach mainline.

Regards
afzal

> On 23/03/2020 07:11, afzal mohammed wrote:
> > Recently all usages of setup_irq() was replaced by request_irq().
> > The replacement in timer-vf-pit.c missed closing parentheses
> > resulting in build error (vf610m4_defconfig). Fix it.
> >
> > Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by
> > request_irq()") Reported-by: kbuild test robot <[email protected]>
> > Signed-off-by: afzal mohammed <[email protected]> ---
> > drivers/clocksource/timer-vf-pit.c | 2 +- 1 file changed, 1
> > insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clocksource/timer-vf-pit.c
> > b/drivers/clocksource/timer-vf-pit.c index
> > 7ad4a8b008c2..1a86a4e7e344 100644 ---
> > a/drivers/clocksource/timer-vf-pit.c +++
> > b/drivers/clocksource/timer-vf-pit.c @@ -129,7 +129,7 @@ static int
> > __init pit_clockevent_init(unsigned long rate, int irq)
> > __raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);
> >
> > BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER |
> > IRQF_IRQPOLL, - "VF pit timer", &clockevent_pit); + "VF
> > pit timer", &clockevent_pit));
> >
> > clockevent_pit.cpumask = cpumask_of(0); clockevent_pit.irq = irq;
> >
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog

2020-04-05 07:32:53

by tip-bot2 for Eric Biggers

Subject: [tip: timers/urgent] clocksource/drivers/timer-vf-pit: Add missing parenthesis

The following commit has been merged into the timers/urgent branch of tip:

Commit-ID: 760a53768610d427990192b5cfdb71310e1373db
Gitweb: https://git.kernel.org/tip/760a53768610d427990192b5cfdb71310e1373db
Author: afzal mohammed <[email protected]>
AuthorDate: Mon, 23 Mar 2020 11:41:30 +05:30
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Sun, 05 Apr 2020 09:24:58 +02:00

clocksource/drivers/timer-vf-pit: Add missing parenthesis

Recently all usage of setup_irq() was replaced by request_irq(). The
replacement in timer-vf-pit.c missed closing parentheses resulting in a build
error (vf610m4_defconfig). Fix it.

Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()")
Reported-by: kbuild test robot <[email protected]>
Signed-off-by: afzal mohammed <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lkml.kernel.org/r/20200323061130.GA6286@afzalpc

---
drivers/clocksource/timer-vf-pit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-vf-pit.c b/drivers/clocksource/timer-vf-pit.c
index 7ad4a8b..1a86a4e 100644
--- a/drivers/clocksource/timer-vf-pit.c
+++ b/drivers/clocksource/timer-vf-pit.c
@@ -129,7 +129,7 @@ static int __init pit_clockevent_init(unsigned long rate, int irq)
__raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);

BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
- "VF pit timer", &clockevent_pit);
+ "VF pit timer", &clockevent_pit));

clockevent_pit.cpumask = cpumask_of(0);
clockevent_pit.irq = irq;