2020-04-05 02:05:30

by Fengping Yu

Subject: [PATCH v3] Add support for MediaTek keypad

This patchset add support to MediaTek matrix keypad.

Change since V2:
- remove extra space and redundant lines
- update keypad devicetree document debounce time unit
- change to use devm_platform_ioremap_resource() to simplify resource management
- use bitmap to store and check keypad state

fengping.yu (2):
add dt-binding document for MediaTek Keypad
add MediaTek keypad driver

.../devicetree/bindings/input/mtk-kpd.txt | 61 +++++
arch/arm64/configs/defconfig | 1 +
drivers/input/keyboard/Kconfig | 7 +
drivers/input/keyboard/Makefile | 1 +
drivers/input/keyboard/mtk-kpd.c | 258 ++++++++++++++++++
5 files changed, 328 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.txt
create mode 100644 drivers/input/keyboard/mtk-kpd.c

--
2.18.0

2020-04-06 13:05:09

by Andy Shevchenko

Subject: Re: [PATCH v3] Add support for MediaTek keypad

On Sun, Apr 05, 2020 at 10:01:13AM +0800, Fengping yu wrote:
>
> This patchset add support to MediaTek matrix keypad.

Seems it has not addressed comments I gave.

>
> Change since V2:
> - remove extra space and redundant lines
> - update keypad devicetree document debounce time unit
> - change to use devm_platform_ioremap_resource() to simplify resource management
> - use bitmap to store and check keypad state
>
> fengping.yu (2):
> add dt-binding document for MediaTek Keypad
> add MediaTek keypad driver
>
> .../devicetree/bindings/input/mtk-kpd.txt | 61 +++++
> arch/arm64/configs/defconfig | 1 +
> drivers/input/keyboard/Kconfig | 7 +
> drivers/input/keyboard/Makefile | 1 +
> drivers/input/keyboard/mtk-kpd.c | 258 ++++++++++++++++++
> 5 files changed, 328 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.txt
> create mode 100644 drivers/input/keyboard/mtk-kpd.c
>
> --
> 2.18.0
>

--
With Best Regards,
Andy Shevchenko