2020-04-07 20:02:12

by Robert Richter

[permalink] [raw]
Subject: Re: [PATCH v1 28/28] i2c: octeon-platdrv: convert to devm_platform_ioremap_resource

On 08.04.20 00:37:41, Dejin Zheng wrote:
> use devm_platform_ioremap_resource() to simplify code, which
> contains platform_get_resource and devm_ioremap_resource.
>
> Signed-off-by: Dejin Zheng <[email protected]>

Acked-by: Robert Richter <[email protected]>

> ---
> drivers/i2c/busses/i2c-octeon-platdrv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-octeon-platdrv.c b/drivers/i2c/busses/i2c-octeon-platdrv.c
> index 64bda83e65ac..0c227963c8d6 100644
> --- a/drivers/i2c/busses/i2c-octeon-platdrv.c
> +++ b/drivers/i2c/busses/i2c-octeon-platdrv.c
> @@ -136,7 +136,6 @@ static int octeon_i2c_probe(struct platform_device *pdev)
> {
> struct device_node *node = pdev->dev.of_node;
> int irq, result = 0, hlc_irq = 0;
> - struct resource *res_mem;
> struct octeon_i2c *i2c;
> bool cn78xx_style;
>
> @@ -167,8 +166,7 @@ static int octeon_i2c_probe(struct platform_device *pdev)
> i2c->roff.twsi_int = 0x10;
> i2c->roff.sw_twsi_ext = 0x18;
>
> - res_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - i2c->twsi_base = devm_ioremap_resource(&pdev->dev, res_mem);
> + i2c->twsi_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(i2c->twsi_base)) {
> result = PTR_ERR(i2c->twsi_base);
> goto out;
> --
> 2.25.0
>