2020-04-08 19:57:46

by Al Cooper

Subject: [PATCH v3 1/4] dt-bindings: Add Broadcom STB USB support

Add DT bindings for Broadcom STB USB EHCI and XHCI drivers.

NOTE: The OHCI driver is not included because it uses the generic
platform driver.

Signed-off-by: Al Cooper <[email protected]>
---
.../bindings/usb/brcm,bcm7445-ehci.yaml | 60 +++++++++++++++++++
.../devicetree/bindings/usb/usb-xhci.txt | 1 +
2 files changed, 61 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml

diff --git a/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml b/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
new file mode 100644
index 000000000000..d41710574b5e
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/brcm,bcm7445-ehci.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom STB USB EHCI Controller Device Tree Bindings
+
+allOf:
+ - $ref: "usb-hcd.yaml"
+
+maintainers:
+ - Al Cooper <[email protected]>
+
+properties:
+ compatible:
+ contains:
+ const: brcm,bcm7445-ehci
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+ description: Clock specifier for the EHCI clock
+
+ clock-names:
+ const: sw_usb
+
+ phys:
+ description: PHY specifier for the USB PHY
+
+ phy-names:
+ const: usbphy
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - phys
+ - clocks
+
+additionalProperties: false
+
+examples:
+ - |
+ usb@f0b00300 {
+ compatible = "brcm,bcm7445-ehci";
+ reg = <0xf0b00300 0xa8>;
+ interrupts = <0x0 0x5a 0x0>;
+ phys = <&usbphy_0 0x0>;
+ phy-names = "usbphy";
+ clocks = <&usb20>;
+ clock-names = "sw_usb";
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
index 3f378951d624..aafc316b5a8e 100644
--- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
@@ -23,6 +23,7 @@ Required properties:
device
- "renesas,rcar-gen3-xhci" for a generic R-Car Gen3 or RZ/G2 compatible
device
+ - "brcm,bcm7445-xhci" for Broadcom STB SoCs with XHCI
- "xhci-platform" (deprecated)

When compatible with the generic version, nodes must list the
--
2.17.1

2020-04-15 21:38:39

by Rob Herring (Arm)

Subject: Re: [PATCH v3 1/4] dt-bindings: Add Broadcom STB USB support

On Wed, Apr 08, 2020 at 02:14:03PM -0400, Al Cooper wrote:
> Add DT bindings for Broadcom STB USB EHCI and XHCI drivers.
>
> NOTE: The OHCI driver is not included because it uses the generic
> platform driver.
>
> Signed-off-by: Al Cooper <[email protected]>
> ---
> .../bindings/usb/brcm,bcm7445-ehci.yaml | 60 +++++++++++++++++++
> .../devicetree/bindings/usb/usb-xhci.txt | 1 +
> 2 files changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml b/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
> new file mode 100644
> index 000000000000..d41710574b5e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: GPL-2.0

Dual license new bindings please:

(GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/brcm,bcm7445-ehci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom STB USB EHCI Controller Device Tree Bindings
> +
> +allOf:
> + - $ref: "usb-hcd.yaml"
> +
> +maintainers:
> + - Al Cooper <[email protected]>
> +
> +properties:
> + compatible:
> + contains:
> + const: brcm,bcm7445-ehci
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> + description: Clock specifier for the EHCI clock
> +
> + clock-names:
> + const: sw_usb
> +
> + phys:
> + description: PHY specifier for the USB PHY

maxItems: 1

And you can drop the description.

> +
> + phy-names:
> + const: usbphy
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - phys
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + usb@f0b00300 {
> + compatible = "brcm,bcm7445-ehci";
> + reg = <0xf0b00300 0xa8>;
> + interrupts = <0x0 0x5a 0x0>;
> + phys = <&usbphy_0 0x0>;
> + phy-names = "usbphy";
> + clocks = <&usb20>;
> + clock-names = "sw_usb";
> + };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> index 3f378951d624..aafc316b5a8e 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -23,6 +23,7 @@ Required properties:
> device
> - "renesas,rcar-gen3-xhci" for a generic R-Car Gen3 or RZ/G2 compatible
> device
> + - "brcm,bcm7445-xhci" for Broadcom STB SoCs with XHCI
> - "xhci-platform" (deprecated)
>
> When compatible with the generic version, nodes must list the
> --
> 2.17.1
>