2020-04-08 20:18:23

by Sam Ravnborg

Subject: [PATCH] fbdev: mx3fb: const pointer to ipu_di_signal_cfg

Laurent Pinchart <[email protected]> and
Jani Nikula <[email protected]> both
suggested to make the pointer to struct ipu_di_signal_cfg const.

Fix this.

Signed-off-by: Sam Ravnborg <[email protected]>
Fixes: 3f6c93ec9254 ("fbdev: mx3fb: avoid warning about psABI change")
Cc: Jani Nikula <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: Enrico Weigelt <[email protected]>
Cc: Bartlomiej Zolnierkiewicz <[email protected]>
Cc: [email protected]
---

Again, sorry. I should have waited a day before applying.

Sam

drivers/video/fbdev/mx3fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
index e13fea3a292f..603731a5a72e 100644
--- a/drivers/video/fbdev/mx3fb.c
+++ b/drivers/video/fbdev/mx3fb.c
@@ -509,7 +509,7 @@ static int sdc_init_panel(struct mx3fb_data *mx3fb, enum ipu_panel panel,
uint16_t h_start_width, uint16_t h_sync_width,
uint16_t h_end_width, uint16_t v_start_width,
uint16_t v_sync_width, uint16_t v_end_width,
- struct ipu_di_signal_cfg *sig)
+ const struct ipu_di_signal_cfg *sig)
{
unsigned long lock_flags;
uint32_t reg;
--
2.20.1

2020-04-08 20:44:01

by Laurent Pinchart

Subject: Re: [PATCH] fbdev: mx3fb: const pointer to ipu_di_signal_cfg

Hi Sam,

Thank you for the patch.

On Wed, Apr 08, 2020 at 08:29:26PM +0200, Sam Ravnborg wrote:
> Laurent Pinchart <[email protected]> and
> Jani Nikula <[email protected]> both
> suggested to make the pointer to struct ipu_di_signal_cfg const.
>
> Fix this.
>
> Signed-off-by: Sam Ravnborg <[email protected]>
> Fixes: 3f6c93ec9254 ("fbdev: mx3fb: avoid warning about psABI change")
> Cc: Jani Nikula <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Sam Ravnborg <[email protected]>
> Cc: Enrico Weigelt <[email protected]>
> Cc: Bartlomiej Zolnierkiewicz <[email protected]>
> Cc: [email protected]

Assuming this is compile-tested,

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
>
> Again, sorry. I should have waited a day before applying.
>
> Sam
>
> drivers/video/fbdev/mx3fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
> index e13fea3a292f..603731a5a72e 100644
> --- a/drivers/video/fbdev/mx3fb.c
> +++ b/drivers/video/fbdev/mx3fb.c
> @@ -509,7 +509,7 @@ static int sdc_init_panel(struct mx3fb_data *mx3fb, enum ipu_panel panel,
> uint16_t h_start_width, uint16_t h_sync_width,
> uint16_t h_end_width, uint16_t v_start_width,
> uint16_t v_sync_width, uint16_t v_end_width,
> - struct ipu_di_signal_cfg *sig)
> + const struct ipu_di_signal_cfg *sig)
> {
> unsigned long lock_flags;
> uint32_t reg;

--
Regards,

Laurent Pinchart

2020-04-13 05:42:05

by Sam Ravnborg

Subject: Re: [PATCH] fbdev: mx3fb: const pointer to ipu_di_signal_cfg

On Wed, Apr 08, 2020 at 11:01:41PM +0300, Laurent Pinchart wrote:
> Hi Sam,
>
> Thank you for the patch.
>
> On Wed, Apr 08, 2020 at 08:29:26PM +0200, Sam Ravnborg wrote:
> > Laurent Pinchart <[email protected]> and
> > Jani Nikula <[email protected]> both
> > suggested to make the pointer to struct ipu_di_signal_cfg const.
> >
> > Fix this.
> >
> > Signed-off-by: Sam Ravnborg <[email protected]>
> > Fixes: 3f6c93ec9254 ("fbdev: mx3fb: avoid warning about psABI change")
> > Cc: Jani Nikula <[email protected]>
> > Cc: Laurent Pinchart <[email protected]>
> > Cc: Arnd Bergmann <[email protected]>
> > Cc: Sam Ravnborg <[email protected]>
> > Cc: Enrico Weigelt <[email protected]>
> > Cc: Bartlomiej Zolnierkiewicz <[email protected]>
> > Cc: [email protected]
>
> Assuming this is compile-tested,
>
> Reviewed-by: Laurent Pinchart <[email protected]>

Thanks. Applied and pushed out to drm-misc-next.

Sam