2020-04-09 08:48:30

by Jason Yan

Subject: [PATCH RESEND] hwmon: (k10temp) make some symbols static

Fix the following sparse warning:

drivers/hwmon/k10temp.c:189:12: warning: symbol 'k10temp_temp_label' was
not declared. Should it be static?
drivers/hwmon/k10temp.c:202:12: warning: symbol 'k10temp_in_label' was
not declared. Should it be static?
drivers/hwmon/k10temp.c:207:12: warning: symbol 'k10temp_curr_label' was
not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/hwmon/k10temp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index 3f37d5d81fe4..9915578533bb 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -186,7 +186,7 @@ static long get_raw_temp(struct k10temp_data *data)
return temp;
}

-const char *k10temp_temp_label[] = {
+static const char *k10temp_temp_label[] = {
"Tctl",
"Tdie",
"Tccd1",
@@ -199,12 +199,12 @@ const char *k10temp_temp_label[] = {
"Tccd8",
};

-const char *k10temp_in_label[] = {
+static const char *k10temp_in_label[] = {
"Vcore",
"Vsoc",
};

-const char *k10temp_curr_label[] = {
+static const char *k10temp_curr_label[] = {
"Icore",
"Isoc",
};
--
2.17.2

2020-04-09 17:27:10

by Guenter Roeck

Subject: Re: [PATCH RESEND] hwmon: (k10temp) make some symbols static

On Thu, Apr 09, 2020 at 04:45:02PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
>
> drivers/hwmon/k10temp.c:189:12: warning: symbol 'k10temp_temp_label' was
> not declared. Should it be static?
> drivers/hwmon/k10temp.c:202:12: warning: symbol 'k10temp_in_label' was
> not declared. Should it be static?
> drivers/hwmon/k10temp.c:207:12: warning: symbol 'k10temp_curr_label' was
> not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>

Applied.

Thanks,
Guenter