2020-04-09 08:57:52

by Jason Yan

[permalink] [raw]

Subject: [PATCH] power: supply: max14656: remove set but not used 'ret'

---

Fix the following gcc warning:

drivers/power/supply/max14656_charger_detector.c:142:6: warning:
variable ‘ret’ set but not used [-Wunused-but-set-variable]
int ret = 0;
^~~

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/power/supply/max14656_charger_detector.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/power/supply/max14656_charger_detector.c b/drivers/power/supply/max14656_charger_detector.c
index 3bbb8b4c8ae7..137f9fafce8c 100644
--- a/drivers/power/supply/max14656_charger_detector.c
+++ b/drivers/power/supply/max14656_charger_detector.c
@@ -139,10 +139,9 @@ static void max14656_irq_worker(struct work_struct *work)

u8 buf[REG_TOTAL_NUM];
u8 chg_type;
- int ret = 0;

- ret = max14656_read_block_reg(chip->client, MAX14656_DEVICE_ID,
- REG_TOTAL_NUM, buf);
+ max14656_read_block_reg(chip->client, MAX14656_DEVICE_ID,
+ REG_TOTAL_NUM, buf);

if ((buf[MAX14656_STATUS_1] & STATUS1_VB_VALID_MASK) &&
(buf[MAX14656_STATUS_1] & STATUS1_CHG_TYPE_MASK)) {
--
2.17.2

2020-04-15 01:08:14

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] power: supply: max14656: remove set but not used 'ret'

---

Hi,

On Thu, Apr 09, 2020 at 04:54:01PM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/power/supply/max14656_charger_detector.c:142:6: warning:
> variable ‘ret’ set but not used [-Wunused-but-set-variable]
> int ret = 0;
> ^~~
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>
> ---

Thanks, queued.

-- Sebastian

> drivers/power/supply/max14656_charger_detector.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/supply/max14656_charger_detector.c b/drivers/power/supply/max14656_charger_detector.c
> index 3bbb8b4c8ae7..137f9fafce8c 100644
> --- a/drivers/power/supply/max14656_charger_detector.c
> +++ b/drivers/power/supply/max14656_charger_detector.c
> @@ -139,10 +139,9 @@ static void max14656_irq_worker(struct work_struct *work)
>
> u8 buf[REG_TOTAL_NUM];
> u8 chg_type;
> - int ret = 0;
>
> - ret = max14656_read_block_reg(chip->client, MAX14656_DEVICE_ID,
> - REG_TOTAL_NUM, buf);
> + max14656_read_block_reg(chip->client, MAX14656_DEVICE_ID,
> + REG_TOTAL_NUM, buf);
>
> if ((buf[MAX14656_STATUS_1] & STATUS1_VB_VALID_MASK) &&
> (buf[MAX14656_STATUS_1] & STATUS1_CHG_TYPE_MASK)) {
> --
> 2.17.2
>

---

Attachments:

(No filename) (1.28 kB)
signature.asc (849.00 B)
Download all attachments