2020-03-10 10:02:16

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Signed-off-by missing for commits in the net-next tree

Hi all,

Commits

b63293e759a1 ("net/mlx5e: Show/set Rx network flow classification rules on ul rep")
6783e8b29f63 ("net/mlx5e: Init ethtool steering for representors")
01013ad355d6 ("net/mlx5e: Show/set Rx flow indir table and RSS hash key on ul rep")

are missing a Signed-off-by from their committer.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-03-10 23:58:18

by Saeed Mahameed

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commits in the net-next tree

On Tue, 2020-03-10 at 21:01 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commits
>
> b63293e759a1 ("net/mlx5e: Show/set Rx network flow classification
> rules on ul rep")
> 6783e8b29f63 ("net/mlx5e: Init ethtool steering for representors")
> 01013ad355d6 ("net/mlx5e: Show/set Rx flow indir table and RSS hash
> key on ul rep")
>

Hi Stephen,

checkpatch doesn't seem to catch such problems..

I count on our CI to do such checks for me, so instead of me writing a
new script every time we hit a new unforeseen issue, i was wondering
where can i find the set of test/scripts you are running ?

> are missing a Signed-off-by from their committer.
>

2020-04-13 08:40:34

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commits in the net-next tree

Hi Saeed,

On Tue, 10 Mar 2020 23:57:31 +0000 Saeed Mahameed <[email protected]> wrote:
>
> On Tue, 2020-03-10 at 21:01 +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commits
> >
> > b63293e759a1 ("net/mlx5e: Show/set Rx network flow classification
> > rules on ul rep")
> > 6783e8b29f63 ("net/mlx5e: Init ethtool steering for representors")
> > 01013ad355d6 ("net/mlx5e: Show/set Rx flow indir table and RSS hash
> > key on ul rep")
> >
>
> Hi Stephen,
>
> checkpatch doesn't seem to catch such problems..
>
> I count on our CI to do such checks for me, so instead of me writing a
> new script every time we hit a new unforeseen issue, i was wondering
> where can i find the set of test/scripts you are running ?

I have attached my scripts ...

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (829.00 B)
 check_commits (1.57 kB)
 check_fixes (4.10 kB)
 (No filename) (499.00 B)
OpenPGP digital signature Download all attachments

2020-04-16 02:00:24

by Saeed Mahameed

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commits in the net-next tree

On Mon, 2020-04-13 at 10:05 +1000, Stephen Rothwell wrote:
> Hi Saeed,
>
> On Tue, 10 Mar 2020 23:57:31 +0000 Saeed Mahameed <
> [email protected]> wrote:
> > On Tue, 2020-03-10 at 21:01 +1100, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Commits
> > >
> > > b63293e759a1 ("net/mlx5e: Show/set Rx network flow
> > > classification
> > > rules on ul rep")
> > > 6783e8b29f63 ("net/mlx5e: Init ethtool steering for
> > > representors")
> > > 01013ad355d6 ("net/mlx5e: Show/set Rx flow indir table and RSS
> > > hash
> > > key on ul rep")
> > >
> >
> > Hi Stephen,
> >
> > checkpatch doesn't seem to catch such problems..
> >
> > I count on our CI to do such checks for me, so instead of me
> > writing a
> > new script every time we hit a new unforeseen issue, i was
> > wondering
> > where can i find the set of test/scripts you are running ?
>
> I have attached my scripts ...
>

Thanks Stephen ! much appreciated.

Saeed.