2020-04-14 13:48:39

by Christian Marangi

Subject: [PATCH] pinctrl: qcom: fix wrong write in update_dual_edge

Fix a typo in the readl/writel accessor conversion where val is used
instead of pol changing the behavior of the original code.

Fixes: 6c73698904aa pinctrl: qcom: Introduce readl/writel accessors

Signed-off-by: Ansuel Smith <[email protected]>
---
drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index 1a948c3f54b7..9f1c9951949e 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -692,7 +692,7 @@ static void msm_gpio_update_dual_edge_pos(struct msm_pinctrl *pctrl,

pol = msm_readl_intr_cfg(pctrl, g);
pol ^= BIT(g->intr_polarity_bit);
- msm_writel_intr_cfg(val, pctrl, g);
+ msm_writel_intr_cfg(pol, pctrl, g);

val2 = msm_readl_io(pctrl, g) & BIT(g->in_bit);
intstat = msm_readl_intr_status(pctrl, g);
--
2.25.1

2020-04-15 06:47:57

by Bjorn Andersson

Subject: Re: [PATCH] pinctrl: qcom: fix wrong write in update_dual_edge

On Mon 13 Apr 17:37 PDT 2020, Ansuel Smith wrote:

> Fix a typo in the readl/writel accessor conversion where val is used
> instead of pol changing the behavior of the original code.
>
> Fixes: 6c73698904aa pinctrl: qcom: Introduce readl/writel accessors
>
> Signed-off-by: Ansuel Smith <[email protected]>

Thank you Ansuel

Reviewed-by: Bjorn Andersson <[email protected]>

Linus, when you apply this please add
Cc: [email protected]

Thanks,
Bjorn

> ---
> drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 1a948c3f54b7..9f1c9951949e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -692,7 +692,7 @@ static void msm_gpio_update_dual_edge_pos(struct msm_pinctrl *pctrl,
>
> pol = msm_readl_intr_cfg(pctrl, g);
> pol ^= BIT(g->intr_polarity_bit);
> - msm_writel_intr_cfg(val, pctrl, g);
> + msm_writel_intr_cfg(pol, pctrl, g);
>
> val2 = msm_readl_io(pctrl, g) & BIT(g->in_bit);
> intstat = msm_readl_intr_status(pctrl, g);
> --
> 2.25.1
>

2020-04-16 17:00:18

by Linus Walleij

Subject: Re: [PATCH] pinctrl: qcom: fix wrong write in update_dual_edge

On Tue, Apr 14, 2020 at 2:37 AM Ansuel Smith <[email protected]> wrote:

> Fix a typo in the readl/writel accessor conversion where val is used
> instead of pol changing the behavior of the original code.
>
> Fixes: 6c73698904aa pinctrl: qcom: Introduce readl/writel accessors
>
> Signed-off-by: Ansuel Smith <[email protected]>

Patch applied for fixes and tagged for stable with Bjorn's ACK.

Yours,
Linus Walleij