2020-04-15 12:07:55

by Jason Yan

Subject: [PATCH] clocksource: atmel-st: remove useless 'status'

Fix the following coccicheck warning:

drivers/clocksource/timer-atmel-st.c:142:6-12: Unneeded variable:
"status". Return "0" on line 166

Signed-off-by: Jason Yan <[email protected]>
---
drivers/clocksource/timer-atmel-st.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
index ab0aabfae5f0..73e8aee445da 100644
--- a/drivers/clocksource/timer-atmel-st.c
+++ b/drivers/clocksource/timer-atmel-st.c
@@ -139,7 +139,6 @@ static int
clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
{
u32 alm;
- int status = 0;
unsigned int val;

BUG_ON(delta < 2);
@@ -163,7 +162,7 @@ clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
alm += delta;
regmap_write(regmap_st, AT91_ST_RTAR, alm);

- return status;
+ return 0;
}

static struct clock_event_device clkevt = {
--
2.21.1

2020-04-15 22:19:32

by Alexandre Belloni

Subject: Re: [PATCH] clocksource: atmel-st: remove useless 'status'

On 14/04/2020 20:02:38+0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/clocksource/timer-atmel-st.c:142:6-12: Unneeded variable:
> "status". Return "0" on line 166
>
> Signed-off-by: Jason Yan <[email protected]>
Acked-by: Alexandre Belloni <[email protected]>

> ---
> drivers/clocksource/timer-atmel-st.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
> index ab0aabfae5f0..73e8aee445da 100644
> --- a/drivers/clocksource/timer-atmel-st.c
> +++ b/drivers/clocksource/timer-atmel-st.c
> @@ -139,7 +139,6 @@ static int
> clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
> {
> u32 alm;
> - int status = 0;
> unsigned int val;
>
> BUG_ON(delta < 2);
> @@ -163,7 +162,7 @@ clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
> alm += delta;
> regmap_write(regmap_st, AT91_ST_RTAR, alm);
>
> - return status;
> + return 0;
> }
>
> static struct clock_event_device clkevt = {
> --
> 2.21.1
>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

2020-04-15 22:43:30

by Daniel Lezcano

Subject: Re: [PATCH] clocksource: atmel-st: remove useless 'status'

On 14/04/2020 14:02, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/clocksource/timer-atmel-st.c:142:6-12: Unneeded variable:
> "status". Return "0" on line 166
>
> Signed-off-by: Jason Yan <[email protected]>
> ---

Applied, thanks


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2020-06-01 13:15:08

by tip-bot2 for Alexey Makhalov

Subject: [tip: timers/core] clocksource/drivers/atmel-st: Remove useless 'status'

The following commit has been merged into the timers/core branch of tip:

Commit-ID: 8c42c0f72d7c4f295646d3eba73f62e5579b1732
Gitweb: https://git.kernel.org/tip/8c42c0f72d7c4f295646d3eba73f62e5579b1732
Author: Jason Yan <[email protected]>
AuthorDate: Tue, 14 Apr 2020 20:02:38 +08:00
Committer: Daniel Lezcano <[email protected]>
CommitterDate: Wed, 15 Apr 2020 10:57:15 +02:00

clocksource/drivers/atmel-st: Remove useless 'status'

Fix the following coccicheck warning:

drivers/clocksource/timer-atmel-st.c:142:6-12: Unneeded variable:
"status". Return "0" on line 166

Signed-off-by: Jason Yan <[email protected]>
Acked-by: Alexandre Belloni <[email protected]>
Signed-off-by: Daniel Lezcano <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/clocksource/timer-atmel-st.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
index ab0aabf..73e8aee 100644
--- a/drivers/clocksource/timer-atmel-st.c
+++ b/drivers/clocksource/timer-atmel-st.c
@@ -139,7 +139,6 @@ static int
clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
{
u32 alm;
- int status = 0;
unsigned int val;

BUG_ON(delta < 2);
@@ -163,7 +162,7 @@ clkevt32k_next_event(unsigned long delta, struct clock_event_device *dev)
alm += delta;
regmap_write(regmap_st, AT91_ST_RTAR, alm);

- return status;
+ return 0;
}

static struct clock_event_device clkevt = {