2020-04-15 22:32:04

by Jason Yan

Subject: [PATCH] scsi: mvsas: make mvst_host_attrs static

Fix the following sparse warning:

drivers/scsi/mvsas/mv_init.c:28:25: warning: symbol 'mvst_host_attrs'
was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/scsi/mvsas/mv_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
index 7af9173c4925..f82728b2c32f 100644
--- a/drivers/scsi/mvsas/mv_init.c
+++ b/drivers/scsi/mvsas/mv_init.c
@@ -25,7 +25,7 @@ static const struct mvs_chip_info mvs_chips[] = {
[chip_1320] = { 2, 4, 0x800, 17, 64, 8, 9, &mvs_94xx_dispatch, },
};

-struct device_attribute *mvst_host_attrs[];
+static struct device_attribute *mvst_host_attrs[];

#define SOC_SAS_NUM 2

@@ -785,7 +785,7 @@ static void __exit mvs_exit(void)
sas_release_transport(mvs_stt);
}

-struct device_attribute *mvst_host_attrs[] = {
+static struct device_attribute *mvst_host_attrs[] = {
&dev_attr_driver_version,
&dev_attr_interrupt_coalescing,
NULL,
--
2.21.1

2020-04-17 21:38:38

by Martin K. Petersen

Subject: Re: [PATCH] scsi: mvsas: make mvst_host_attrs static

Jason,

> Fix the following sparse warning:
>
> drivers/scsi/mvsas/mv_init.c:28:25: warning: symbol 'mvst_host_attrs'
> was not declared. Should it be static?

Applied to 5.8/scsi-queue, thanks!

--
Martin K. Petersen Oracle Linux Engineering