2020-04-16 00:22:16

by Takashi Iwai

Subject: [PATCH] firmware: Drop unused pages field from struct firmware

The struct firmware contains a page table pointer that was used only
internally in the past. Since the actual page tables are referred
from struct fw_priv and should be never from struct firmware, we can
drop this unused field gracefully.

Signed-off-by: Takashi Iwai <[email protected]>
---
drivers/base/firmware_loader/main.c | 3 ---
include/linux/firmware.h | 1 -
2 files changed, 4 deletions(-)

diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
index 76f79913916d..5296aaca35cf 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -548,9 +548,6 @@ static void firmware_free_data(const struct firmware *fw)
static void fw_set_page_data(struct fw_priv *fw_priv, struct firmware *fw)
{
fw->priv = fw_priv;
-#ifdef CONFIG_FW_LOADER_USER_HELPER
- fw->pages = fw_priv->pages;
-#endif
fw->size = fw_priv->size;
fw->data = fw_priv->data;

diff --git a/include/linux/firmware.h b/include/linux/firmware.h
index 4bbd0afd91b7..cb3e2c06ed8a 100644
--- a/include/linux/firmware.h
+++ b/include/linux/firmware.h
@@ -12,7 +12,6 @@
struct firmware {
size_t size;
const u8 *data;
- struct page **pages;

/* firmware loader private fields */
void *priv;
--
2.25.0

2020-04-16 05:20:27

by Luis Chamberlain

Subject: Re: [PATCH] firmware: Drop unused pages field from struct firmware

On Wed, Apr 15, 2020 at 06:45:00PM +0200, Takashi Iwai wrote:
> The struct firmware contains a page table pointer that was used only
> internally in the past. Since the actual page tables are referred
> from struct fw_priv and should be never from struct firmware, we can
> drop this unused field gracefully.
>
> Signed-off-by: Takashi Iwai <[email protected]>

Acked-by: Luis Chamberlain <[email protected]>

Luis