2020-04-16 01:04:19

by Stephen Boyd

Subject: [PATCH] soc: qcom: cmd-db: Use 5 digits for printing address

The top few bits aren't relevant to pad out because they're always zero.
Let's just print 5 digits instead of 8 so that it's a little shorter and
more readable.

Suggested-by: Lina Iyer <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/soc/qcom/cmd-db.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
index 57382b64f1da..4f8b739c6485 100644
--- a/drivers/soc/qcom/cmd-db.c
+++ b/drivers/soc/qcom/cmd-db.c
@@ -278,7 +278,7 @@ static int cmd_db_debugfs_dump(struct seq_file *seq, void *p)

ent = rsc_to_entry_header(rsc);
for (j = 0; j < le16_to_cpu(rsc->cnt); j++, ent++) {
- seq_printf(seq, "0x%08x: %*pEp", le32_to_cpu(ent->addr),
+ seq_printf(seq, "0x%05x: %*pEp", le32_to_cpu(ent->addr),
(int)sizeof(ent->id), ent->id);

len = le16_to_cpu(ent->len);

base-commit: d6815c5c43d4f9d18e557d27fd27ae8d9cfd450c
prerequisite-patch-id: fc235b174200bb1b24876628a89a841d1c2e4aad
--
Sent by a computer, using git, on the internet

2020-04-16 01:05:05

by Lina Iyer

Subject: Re: [PATCH] soc: qcom: cmd-db: Use 5 digits for printing address

On Wed, Apr 15 2020 at 13:29 -0600, Stephen Boyd wrote:
>The top few bits aren't relevant to pad out because they're always zero.
>Let's just print 5 digits instead of 8 so that it's a little shorter and
>more readable.
>
>Suggested-by: Lina Iyer <[email protected]>
>Signed-off-by: Stephen Boyd <[email protected]>
Reviewed-by: Lina Iyer <[email protected]>