The panel connector type should be set by the panel not the bridge, so
remove the connector_type assignment.
Signed-off-by: Enric Balletbo i Serra <[email protected]>
---
drivers/gpu/drm/bridge/parade-ps8640.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
index 956b76e0a44d..13755d278db6 100644
--- a/drivers/gpu/drm/bridge/parade-ps8640.c
+++ b/drivers/gpu/drm/bridge/parade-ps8640.c
@@ -278,8 +278,6 @@ static int ps8640_probe(struct i2c_client *client)
if (!panel)
return -ENODEV;
- panel->connector_type = DRM_MODE_CONNECTOR_eDP;
-
ps_bridge->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
if (IS_ERR(ps_bridge->panel_bridge))
return PTR_ERR(ps_bridge->panel_bridge);
--
2.25.1
Hi Enric,
Thank you for the patch.
On Thu, Apr 16, 2020 at 06:44:04PM +0200, Enric Balletbo i Serra wrote:
> The panel connector type should be set by the panel not the bridge, so
> remove the connector_type assignment.
>
> Signed-off-by: Enric Balletbo i Serra <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]>
> ---
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> index 956b76e0a44d..13755d278db6 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -278,8 +278,6 @@ static int ps8640_probe(struct i2c_client *client)
> if (!panel)
> return -ENODEV;
>
> - panel->connector_type = DRM_MODE_CONNECTOR_eDP;
> -
> ps_bridge->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
> if (IS_ERR(ps_bridge->panel_bridge))
> return PTR_ERR(ps_bridge->panel_bridge);
--
Regards,
Laurent Pinchart
On Thu, Apr 16, 2020 at 06:44:04PM +0200, Enric Balletbo i Serra wrote:
> The panel connector type should be set by the panel not the bridge, so
> remove the connector_type assignment.
>
> Signed-off-by: Enric Balletbo i Serra <[email protected]>
Thanks, applied to drm-misc-next.
Sam
> ---
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> index 956b76e0a44d..13755d278db6 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -278,8 +278,6 @@ static int ps8640_probe(struct i2c_client *client)
> if (!panel)
> return -ENODEV;
>
> - panel->connector_type = DRM_MODE_CONNECTOR_eDP;
> -
> ps_bridge->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
> if (IS_ERR(ps_bridge->panel_bridge))
> return PTR_ERR(ps_bridge->panel_bridge);
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel