2020-04-19 15:48:46

by Aishwarya Ramakrishnan

Subject: [PATCH] net: sun: Remove unneeded cast from memory allocation

Remove casting the values returned by memory allocation function.

Coccinelle emits WARNING: casting value returned by memory allocation
function to (struct cas_init_block *) is useless.

This issue was detected by using the Coccinelle software.

Signed-off-by: Aishwarya Ramakrishnan <[email protected]>
---
drivers/net/ethernet/sun/cassini.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c
index e6d1aa882fa5..3ee6ab104cb9 100644
--- a/drivers/net/ethernet/sun/cassini.c
+++ b/drivers/net/ethernet/sun/cassini.c
@@ -5059,7 +5059,7 @@ static int cas_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
if (cp->cas_flags & CAS_FLAG_SATURN)
cas_saturn_firmware_init(cp);

- cp->init_block = (struct cas_init_block *)
+ cp->init_block =
pci_alloc_consistent(pdev, sizeof(struct cas_init_block),
&cp->block_dvma);
if (!cp->init_block) {
--
2.17.1

2020-04-20 19:25:03

by David Miller

Subject: Re: [PATCH] net: sun: Remove unneeded cast from memory allocation

From: Aishwarya Ramakrishnan <[email protected]>
Date: Sun, 19 Apr 2020 21:14:43 +0530

> Remove casting the values returned by memory allocation function.
>
> Coccinelle emits WARNING: casting value returned by memory allocation
> function to (struct cas_init_block *) is useless.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Aishwarya Ramakrishnan <[email protected]>

Applied to net-next, thanks.