2020-04-20 12:09:54

by Jason Yan

Subject: [PATCH] ptp: Remove unneeded conversion to bool

The '==' expression itself is bool, no need to convert it to bool again.
This fixes the following coccicheck warning:

drivers/ptp/ptp_ines.c:403:55-60: WARNING: conversion to bool not
needed here
drivers/ptp/ptp_ines.c:404:55-60: WARNING: conversion to bool not
needed here

Signed-off-by: Jason Yan <[email protected]>
---
drivers/ptp/ptp_ines.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ptp/ptp_ines.c b/drivers/ptp/ptp_ines.c
index dfda54cbd866..52d77db39829 100644
--- a/drivers/ptp/ptp_ines.c
+++ b/drivers/ptp/ptp_ines.c
@@ -400,8 +400,8 @@ static int ines_hwtstamp(struct mii_timestamper *mii_ts, struct ifreq *ifr)
ines_write32(port, ts_stat_rx, ts_stat_rx);
ines_write32(port, ts_stat_tx, ts_stat_tx);

- port->rxts_enabled = ts_stat_rx == TS_ENABLE ? true : false;
- port->txts_enabled = ts_stat_tx == TS_ENABLE ? true : false;
+ port->rxts_enabled = ts_stat_rx == TS_ENABLE;
+ port->txts_enabled = ts_stat_tx == TS_ENABLE;

spin_unlock_irqrestore(&port->lock, flags);

--
2.21.1

2020-04-21 22:47:21

by David Miller

Subject: Re: [PATCH] ptp: Remove unneeded conversion to bool

From: Jason Yan <[email protected]>
Date: Mon, 20 Apr 2020 20:34:31 +0800

> The '==' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/ptp/ptp_ines.c:403:55-60: WARNING: conversion to bool not
> needed here
> drivers/ptp/ptp_ines.c:404:55-60: WARNING: conversion to bool not
> needed here
>
> Signed-off-by: Jason Yan <[email protected]>

Applied to net-next.