2020-04-20 13:46:51

by Jason Yan

Subject: [PATCH] perf annotate: Remove unneeded conversion to bool

The '>' expression itself is bool, no need to convert it to bool again.
This fixes the following coccicheck warning:

tools/perf/ui/browsers/annotate.c:212:30-35: WARNING: conversion to bool
not needed here

Signed-off-by: Jason Yan <[email protected]>
---
tools/perf/ui/browsers/annotate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index 9023267e5643..bd77825fd5a1 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -209,7 +209,7 @@ static void annotate_browser__draw_current_jump(struct ui_browser *browser)
ui_browser__mark_fused(browser,
pcnt_width + 3 + notes->widths.addr + width,
from - 1,
- to > from ? true : false);
+ to > from);
}
}

--
2.21.1

2020-04-20 16:37:34

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf annotate: Remove unneeded conversion to bool

Em Mon, Apr 20, 2020 at 08:35:28PM +0800, Jason Yan escreveu:
> The '>' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> tools/perf/ui/browsers/annotate.c:212:30-35: WARNING: conversion to bool
> not needed here

Thanks, applied.

- Arnaldo