2020-04-17 08:58:26

by Jason Yan

Subject: [PATCH] backlight: lms501kf03: remove unused 'seq_sleep_in' and 'seq_up_dn'

Fix the following gcc warning:

drivers/video/backlight/lms501kf03.c:96:28: warning: ‘seq_sleep_in’
defined but not used [-Wunused-const-variable=]
static const unsigned char seq_sleep_in[] = {
^~~~~~~~~~~~
drivers/video/backlight/lms501kf03.c:92:28: warning: ‘seq_up_dn’ defined
but not used [-Wunused-const-variable=]
static const unsigned char seq_up_dn[] = {
^~~~~~~~~

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/video/backlight/lms501kf03.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/video/backlight/lms501kf03.c b/drivers/video/backlight/lms501kf03.c
index 8ae32e3573c1..c1bd02bb8b2e 100644
--- a/drivers/video/backlight/lms501kf03.c
+++ b/drivers/video/backlight/lms501kf03.c
@@ -89,14 +89,6 @@ static const unsigned char seq_rgb_gamma[] = {
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
};

-static const unsigned char seq_up_dn[] = {
- 0x36, 0x10,
-};
-
-static const unsigned char seq_sleep_in[] = {
- 0x10,
-};
-
static const unsigned char seq_sleep_out[] = {
0x11,
};
--
2.21.1

2020-04-20 16:38:56

by Daniel Thompson

Subject: Re: [PATCH] backlight: lms501kf03: remove unused 'seq_sleep_in' and 'seq_up_dn'

On Fri, Apr 17, 2020 at 05:22:57PM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/video/backlight/lms501kf03.c:96:28: warning: ‘seq_sleep_in’
> defined but not used [-Wunused-const-variable=]
> static const unsigned char seq_sleep_in[] = {
> ^~~~~~~~~~~~
> drivers/video/backlight/lms501kf03.c:92:28: warning: ‘seq_up_dn’ defined
> but not used [-Wunused-const-variable=]
> static const unsigned char seq_up_dn[] = {
> ^~~~~~~~~
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>


> ---
> drivers/video/backlight/lms501kf03.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/video/backlight/lms501kf03.c b/drivers/video/backlight/lms501kf03.c
> index 8ae32e3573c1..c1bd02bb8b2e 100644
> --- a/drivers/video/backlight/lms501kf03.c
> +++ b/drivers/video/backlight/lms501kf03.c
> @@ -89,14 +89,6 @@ static const unsigned char seq_rgb_gamma[] = {
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> };
>
> -static const unsigned char seq_up_dn[] = {
> - 0x36, 0x10,
> -};
> -
> -static const unsigned char seq_sleep_in[] = {
> - 0x10,
> -};
> -
> static const unsigned char seq_sleep_out[] = {
> 0x11,
> };
> --
> 2.21.1
>