2020-04-21 03:42:01

by Jason Yan

Subject: [PATCH] scsi: bfa: remove unneeded semicolon in bfa_fcs_rport.c

Fix the following coccicheck warning:

drivers/scsi/bfa/bfa_fcs_rport.c:2452:2-3: Unneeded semicolon
drivers/scsi/bfa/bfa_fcs_rport.c:1578:3-4: Unneeded semicolon

Signed-off-by: Jason Yan <[email protected]>
---
drivers/scsi/bfa/bfa_fcs_rport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/bfa/bfa_fcs_rport.c b/drivers/scsi/bfa/bfa_fcs_rport.c
index 82801b366500..fc294e1950a6 100644
--- a/drivers/scsi/bfa/bfa_fcs_rport.c
+++ b/drivers/scsi/bfa/bfa_fcs_rport.c
@@ -1575,7 +1575,7 @@ bfa_fcs_rport_sm_nsdisc_sent(struct bfa_fcs_rport_s *rport,
bfa_timer_start(rport->fcs->bfa, &rport->timer,
bfa_fcs_rport_timeout, rport,
bfa_fcs_rport_del_timeout);
- };
+ }
break;

case RPSM_EVENT_DELETE:
@@ -2449,7 +2449,7 @@ bfa_fcs_rport_hal_online_action(struct bfa_fcs_rport_s *rport)
bfa_fcs_itnim_brp_online(rport->itnim);
if (!BFA_FCS_PID_IS_WKA(rport->pid))
bfa_fcs_rpf_rport_online(rport);
- };
+ }

wwn2str(lpwwn_buf, bfa_fcs_lport_get_pwwn(port));
wwn2str(rpwwn_buf, rport->pwwn);
--
2.21.1

2020-04-27 20:25:40

by Martin K. Petersen

Subject: Re: [PATCH] scsi: bfa: remove unneeded semicolon in bfa_fcs_rport.c

On Tue, 21 Apr 2020 11:39:57 +0800, Jason Yan wrote:

> Fix the following coccicheck warning:
>
> drivers/scsi/bfa/bfa_fcs_rport.c:2452:2-3: Unneeded semicolon
> drivers/scsi/bfa/bfa_fcs_rport.c:1578:3-4: Unneeded semicolon

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: bfa: Remove unneeded semicolon in bfa_fcs_rport.c
https://git.kernel.org/mkp/scsi/c/f71ded01cc3f

--
Martin K. Petersen Oracle Linux Engineering