2020-04-22 09:27:41

by Oleksij Rempel

Subject: [PATCH net-next v5 1/4] dt-bindings: net: phy: Add support for NXP TJA11xx

Document the NXP TJA11xx PHY bindings.

Signed-off-by: Oleksij Rempel <[email protected]>
---
.../devicetree/bindings/net/nxp,tja11xx.yaml | 61 +++++++++++++++++++
1 file changed, 61 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/nxp,tja11xx.yaml

diff --git a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
new file mode 100644
index 0000000000000..42be0255512b3
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: GPL-2.0+
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/nxp,tja11xx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP TJA11xx PHY
+
+maintainers:
+ - Andrew Lunn <[email protected]>
+ - Florian Fainelli <[email protected]>
+ - Heiner Kallweit <[email protected]>
+
+description:
+ Bindings for NXP TJA11xx automotive PHYs
+
+allOf:
+ - $ref: ethernet-phy.yaml#
+
+patternProperties:
+ "^ethernet-phy@[0-9a-f]+$":
+ type: object
+ description: |
+ Some packages have multiple PHYs. Secondary PHY should be defines as
+ subnode of the first (parent) PHY.
+
+ properties:
+ reg:
+ minimum: 0
+ maximum: 31
+ description:
+ The ID number for the child PHY. Should be +1 of parent PHY.
+
+ required:
+ - reg
+
+examples:
+ - |
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ tja1101_phy0: ethernet-phy@4 {
+ reg = <0x4>;
+ };
+ };
+ - |
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ tja1102_phy0: ethernet-phy@4 {
+ reg = <0x4>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ tja1102_phy1: ethernet-phy@5 {
+ reg = <0x5>;
+ };
+ };
+ };
--
2.26.1

2020-04-22 13:53:51

by Andrew Lunn

Subject: Re: [PATCH net-next v5 1/4] dt-bindings: net: phy: Add support for NXP TJA11xx

On Wed, Apr 22, 2020 at 11:24:53AM +0200, Oleksij Rempel wrote:
> Document the NXP TJA11xx PHY bindings.
>
> Signed-off-by: Oleksij Rempel <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2020-04-23 03:20:20

by Florian Fainelli

Subject: Re: [PATCH net-next v5 1/4] dt-bindings: net: phy: Add support for NXP TJA11xx

On 4/22/2020 2:24 AM, Oleksij Rempel wrote:
> Document the NXP TJA11xx PHY bindings.
>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> .../devicetree/bindings/net/nxp,tja11xx.yaml | 61 +++++++++++++++++++
> 1 file changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
> new file mode 100644
> index 0000000000000..42be0255512b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: GPL-2.0+
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/nxp,tja11xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP TJA11xx PHY
> +
> +maintainers:
> + - Andrew Lunn <[email protected]>
> + - Florian Fainelli <[email protected]>
> + - Heiner Kallweit <[email protected]>

I would have expected to have you listed as a maintainer of this
binding, but fair enough.

> +
> +description:
> + Bindings for NXP TJA11xx automotive PHYs
> +
> +allOf:
> + - $ref: ethernet-phy.yaml#
> +
> +patternProperties:
> + "^ethernet-phy@[0-9a-f]+$":
> + type: object
> + description: |
> + Some packages have multiple PHYs. Secondary PHY should be defines as

should be defined as a subnode.
--
Florian