2020-04-15 13:08:59

by Manivannan Sadhasivam

Subject: [RESEND PATCH v3 1/3] dt-bindings: iio: chemical: Add binding for CCS811 VOC sensor

From: Manivannan Sadhasivam <[email protected]>

This commit adds devicetree binding for AMS CCS811 VOC sensor.

Signed-off-by: Manivannan Sadhasivam <[email protected]>
---
.../bindings/iio/chemical/ams,ccs811.yaml | 51 +++++++++++++++++++
1 file changed, 51 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml

diff --git a/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml b/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
new file mode 100644
index 000000000000..5cb068666a3e
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/chemical/ams,ccs811.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: AMS CCS811 VOC Sensor
+
+maintainers:
+ - Narcisa Vasile <[email protected]>
+
+description: |
+ Ultra-Low Power Digital Gas Sensor for Monitoring Indoor Air Quality.
+
+properties:
+ compatible:
+ enum:
+ - ams,ccs811
+ reg:
+ maxItems: 1
+
+ reset-gpios:
+ description: GPIO connected to the nRESET line. This is an active low
+ input to CCS811.
+ maxItems: 1
+
+ wakeup-gpios:
+ description: GPIO connected to the nWAKE line. This is an active low
+ input to CCS811.
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ voc@5b {
+ compatible = "ams,ccs811";
+ reg = <0x5b>;
+ reset-gpios = <&gpioa 11 GPIO_ACTIVE_LOW>;
+ wakeup-gpios = <&gpioa 12 GPIO_ACTIVE_LOW>;
+ };
+ };
+
+...
--
2.17.1

2020-04-20 21:12:45

by Rob Herring (Arm)

Subject: Re: [RESEND PATCH v3 1/3] dt-bindings: iio: chemical: Add binding for CCS811 VOC sensor

On Wed, Apr 15, 2020 at 12:19:28AM +0530, [email protected] wrote:
> From: Manivannan Sadhasivam <[email protected]>
>
> This commit adds devicetree binding for AMS CCS811 VOC sensor.
>
> Signed-off-by: Manivannan Sadhasivam <[email protected]>
> ---
> .../bindings/iio/chemical/ams,ccs811.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml b/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
> new file mode 100644
> index 000000000000..5cb068666a3e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/chemical/ams,ccs811.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AMS CCS811 VOC Sensor
> +
> +maintainers:
> + - Narcisa Vasile <[email protected]>
> +
> +description: |
> + Ultra-Low Power Digital Gas Sensor for Monitoring Indoor Air Quality.
> +
> +properties:
> + compatible:
> + enum:
> + - ams,ccs811
> + reg:
> + maxItems: 1
> +
> + reset-gpios:
> + description: GPIO connected to the nRESET line. This is an active low
> + input to CCS811.
> + maxItems: 1
> +
> + wakeup-gpios:
> + description: GPIO connected to the nWAKE line. This is an active low
> + input to CCS811.
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg

Add:

additionalProperties: false

With that,

Reviewed-by: Rob Herring <[email protected]>

2020-04-22 18:28:44

by Manivannan Sadhasivam

Subject: Re: [RESEND PATCH v3 1/3] dt-bindings: iio: chemical: Add binding for CCS811 VOC sensor

On Mon, Apr 20, 2020 at 04:11:11PM -0500, Rob Herring wrote:
> On Wed, Apr 15, 2020 at 12:19:28AM +0530, [email protected] wrote:
> > From: Manivannan Sadhasivam <[email protected]>
> >
> > This commit adds devicetree binding for AMS CCS811 VOC sensor.
> >
> > Signed-off-by: Manivannan Sadhasivam <[email protected]>
> > ---
> > .../bindings/iio/chemical/ams,ccs811.yaml | 51 +++++++++++++++++++
> > 1 file changed, 51 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml b/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
> > new file mode 100644
> > index 000000000000..5cb068666a3e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
> > @@ -0,0 +1,51 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/chemical/ams,ccs811.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: AMS CCS811 VOC Sensor
> > +
> > +maintainers:
> > + - Narcisa Vasile <[email protected]>
> > +
> > +description: |
> > + Ultra-Low Power Digital Gas Sensor for Monitoring Indoor Air Quality.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - ams,ccs811
> > + reg:
> > + maxItems: 1
> > +
> > + reset-gpios:
> > + description: GPIO connected to the nRESET line. This is an active low
> > + input to CCS811.
> > + maxItems: 1
> > +
> > + wakeup-gpios:
> > + description: GPIO connected to the nWAKE line. This is an active low
> > + input to CCS811.
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
>
> Add:
>
> additionalProperties: false
>

Hi Jonathan,

Do you want me to spin another series or you can add it while applying?

Thanks,
Mani

> With that,
>
> Reviewed-by: Rob Herring <[email protected]>

2020-04-25 15:26:12

by Jonathan Cameron

Subject: Re: [RESEND PATCH v3 1/3] dt-bindings: iio: chemical: Add binding for CCS811 VOC sensor

On Wed, 22 Apr 2020 23:57:15 +0530
Manivannan Sadhasivam <[email protected]> wrote:

> On Mon, Apr 20, 2020 at 04:11:11PM -0500, Rob Herring wrote:
> > On Wed, Apr 15, 2020 at 12:19:28AM +0530, [email protected] wrote:
> > > From: Manivannan Sadhasivam <[email protected]>
> > >
> > > This commit adds devicetree binding for AMS CCS811 VOC sensor.
> > >
> > > Signed-off-by: Manivannan Sadhasivam <[email protected]>
> > > ---
> > > .../bindings/iio/chemical/ams,ccs811.yaml | 51 +++++++++++++++++++
> > > 1 file changed, 51 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml b/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
> > > new file mode 100644
> > > index 000000000000..5cb068666a3e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
> > > @@ -0,0 +1,51 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/iio/chemical/ams,ccs811.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: AMS CCS811 VOC Sensor
> > > +
> > > +maintainers:
> > > + - Narcisa Vasile <[email protected]>
> > > +
> > > +description: |
> > > + Ultra-Low Power Digital Gas Sensor for Monitoring Indoor Air Quality.
> > > +
> > > +properties:
> > > + compatible:
> > > + enum:
> > > + - ams,ccs811
> > > + reg:
> > > + maxItems: 1
> > > +
> > > + reset-gpios:
> > > + description: GPIO connected to the nRESET line. This is an active low
> > > + input to CCS811.
> > > + maxItems: 1
> > > +
> > > + wakeup-gpios:
> > > + description: GPIO connected to the nWAKE line. This is an active low
> > > + input to CCS811.
> > > + maxItems: 1
> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> >
> > Add:
> >
> > additionalProperties: false
> >
>
> Hi Jonathan,
>
> Do you want me to spin another series or you can add it while applying?
Added whilst applying.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to poke at it.

Thanks,

Jonathan

>
> Thanks,
> Mani
>
> > With that,
> >
> > Reviewed-by: Rob Herring <[email protected]>