2020-04-23 01:26:14

by Fengping Yu

Subject: [PATCH v5] add mtk matrix keypad driver for keypad on MTK SoC

Change since v4:
- remove extra space and redundant lines
- remove disable_irq_nosync and enable_irq in irq handler
- put defconfig as a single patch
- unified device properties interface for ACPI and device trees
- fixed other issue according reviewer comments

fengping.yu (3):
dt-bindings: add matrix keypad documentation
arm64: configs: defconfig: enable mtk keypad config
drivers: input: keyboard: add mtk keypad driver

.../devicetree/bindings/input/mtk-kpd.txt | 61 +++++
arch/arm64/configs/defconfig | 1 +
drivers/input/keyboard/Kconfig | 9 +
drivers/input/keyboard/Makefile | 1 +
drivers/input/keyboard/mtk-kpd.c | 242 ++++++++++++++++++
5 files changed, 314 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.txt
create mode 100644 drivers/input/keyboard/mtk-kpd.c

--
2.18.0

2020-04-23 05:31:37

by Marco Felsch

Subject: Re: [PATCH v5] add mtk matrix keypad driver for keypad on MTK SoC

Hi Fengping,

On 20-04-23 09:19, Fengping yu wrote:
>
> Change since v4:
> - remove extra space and redundant lines
> - remove disable_irq_nosync and enable_irq in irq handler
> - put defconfig as a single patch
> - unified device properties interface for ACPI and device trees

This is a good changelog for reviewers.

> - fixed other issue according reviewer comments

This one is a bit useless..

Regards,
Marco

> fengping.yu (3):
> dt-bindings: add matrix keypad documentation
> arm64: configs: defconfig: enable mtk keypad config
> drivers: input: keyboard: add mtk keypad driver
>
> .../devicetree/bindings/input/mtk-kpd.txt | 61 +++++
> arch/arm64/configs/defconfig | 1 +
> drivers/input/keyboard/Kconfig | 9 +
> drivers/input/keyboard/Makefile | 1 +
> drivers/input/keyboard/mtk-kpd.c | 242 ++++++++++++++++++
> 5 files changed, 314 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.txt
> create mode 100644 drivers/input/keyboard/mtk-kpd.c
>
> --
> 2.18.0
>

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |