2020-04-24 08:25:27

by Michael Kao

[permalink] [raw]
Subject: [PATCH] [RESEND] arm64: dts: mt8173: fix cooling device range

When thermal reaches target temperature,it would be pinned to state 0
(max frequency and power).
Fix the throttling range to no limit.

Signed-off-by: Hsin-Yi Wang <[email protected]>
Signed-off-by: Michael Kao <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index ccb8e88a60c5..cae2cec46cdc 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -19,6 +19,7 @@
#include <dt-bindings/power/mt8173-power.h>
#include <dt-bindings/reset/mt8173-resets.h>
#include <dt-bindings/gce/mt8173-gce.h>
+#include <dt-bindings/thermal/thermal.h>
#include "mt8173-pinfunc.h"

/ {
@@ -294,14 +295,18 @@
cooling-maps {
map@0 {
trip = <&target>;
- cooling-device = <&cpu0 0 0>,
- <&cpu1 0 0>;
+ cooling-device = <&cpu0 THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>,
+ <&cpu1 THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>;
contribution = <3072>;
};
map@1 {
trip = <&target>;
- cooling-device = <&cpu2 0 0>,
- <&cpu3 0 0>;
+ cooling-device = <&cpu2 THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>,
+ <&cpu3 THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>;
contribution = <1024>;
};
};
--
2.18.0


2020-05-15 15:35:59

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH] [RESEND] arm64: dts: mt8173: fix cooling device range



On 24/04/2020 10:23, Michael Kao wrote:
> When thermal reaches target temperature,it would be pinned to state 0
> (max frequency and power).
> Fix the throttling range to no limit.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> Signed-off-by: Michael Kao <[email protected]>

applied to v5.7-next/dts64

Thanks!

> ---
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index ccb8e88a60c5..cae2cec46cdc 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -19,6 +19,7 @@
> #include <dt-bindings/power/mt8173-power.h>
> #include <dt-bindings/reset/mt8173-resets.h>
> #include <dt-bindings/gce/mt8173-gce.h>
> +#include <dt-bindings/thermal/thermal.h>
> #include "mt8173-pinfunc.h"
>
> / {
> @@ -294,14 +295,18 @@
> cooling-maps {
> map@0 {
> trip = <&target>;
> - cooling-device = <&cpu0 0 0>,
> - <&cpu1 0 0>;
> + cooling-device = <&cpu0 THERMAL_NO_LIMIT
> + THERMAL_NO_LIMIT>,
> + <&cpu1 THERMAL_NO_LIMIT
> + THERMAL_NO_LIMIT>;
> contribution = <3072>;
> };
> map@1 {
> trip = <&target>;
> - cooling-device = <&cpu2 0 0>,
> - <&cpu3 0 0>;
> + cooling-device = <&cpu2 THERMAL_NO_LIMIT
> + THERMAL_NO_LIMIT>,
> + <&cpu3 THERMAL_NO_LIMIT
> + THERMAL_NO_LIMIT>;
> contribution = <1024>;
> };
> };
>