2020-04-24 15:55:58

by YoungJun.park

[permalink] [raw]
Subject: [PATCH] fs: fixup redundant indentation.

From: Youngjun Park <[email protected]>

Signed-off-by: Youngjun Park <[email protected]>

fixup redundant indentation on the label.
---
fs/kernfs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index 34366db3620d..7fb5d1e48ef7 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -544,7 +544,7 @@ static int kernfs_get_open_node(struct kernfs_node *kn,
{
struct kernfs_open_node *on, *new_on = NULL;

- retry:
+retry:
mutex_lock(&kernfs_open_file_mutex);
spin_lock_irq(&kernfs_open_node_lock);

--
2.17.1


2020-04-28 13:06:08

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] fs: fixup redundant indentation.

On Fri, Apr 24, 2020 at 08:53:34AM -0700, Youngjun Park wrote:
> From: Youngjun Park <[email protected]>
>
> Signed-off-by: Youngjun Park <[email protected]>
>
> fixup redundant indentation on the label.
> ---
> fs/kernfs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

signed-off-by needs to go last.

And this fix is not needed, the existing code is fine.

thanks,

greg k-h