2020-04-26 09:46:53

by Jason Yan

Subject: [PATCH] usb: musb: use true for 'use_dma'

Fix the following coccicheck warning:

drivers/usb/musb/musb_core.c:1798:12-19: WARNING: Assignment of 0/1 to
bool variable

Signed-off-by: Jason Yan <[email protected]>
---
drivers/usb/musb/musb_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index d590110539ab..a0eba889ec61 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -1795,7 +1795,7 @@ irqreturn_t musb_interrupt(struct musb *musb)
EXPORT_SYMBOL_GPL(musb_interrupt);

#ifndef CONFIG_MUSB_PIO_ONLY
-static bool use_dma = 1;
+static bool use_dma = true;

/* "modprobe ... use_dma=0" etc */
module_param(use_dma, bool, 0644);
--
2.21.1

2020-05-20 02:41:24

by Bin Liu

Subject: Re: [PATCH] usb: musb: use true for 'use_dma'

On Sun, Apr 26, 2020 at 05:41:30PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/usb/musb/musb_core.c:1798:12-19: WARNING: Assignment of 0/1 to
> bool variable
>
> Signed-off-by: Jason Yan <[email protected]>

Queued for v5.8. Thanks.

-Bin.