2020-04-26 09:46:28

by Jason Yan

[permalink] [raw]
Subject: [PATCH] scsi: ufs: use true for bool variables in ufshcd_complete_dev_init()

Fix the following coccicheck warning:

drivers/scsi/ufs/ufshcd.c:4140:6-14: WARNING: Assignment of 0/1 to bool
variable

Signed-off-by: Jason Yan <[email protected]>
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 52990c39bc16..fd1541111cc3 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4137,7 +4137,7 @@ static int ufshcd_complete_dev_init(struct ufs_hba *hba)
{
int i;
int err;
- bool flag_res = 1;
+ bool flag_res = true;

err = ufshcd_query_flag_retry(hba, UPIU_QUERY_OPCODE_SET_FLAG,
QUERY_FLAG_IDN_FDEVICEINIT, NULL);
--
2.21.1


2020-04-27 22:53:03

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: ufs: use true for bool variables in ufshcd_complete_dev_init()

On Sun, 26 Apr 2020 17:43:05 +0800, Jason Yan wrote:

> Fix the following coccicheck warning:
>
> drivers/scsi/ufs/ufshcd.c:4140:6-14: WARNING: Assignment of 0/1 to bool
> variable

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: ufs: Use true for bool variables in ufshcd_complete_dev_init()
https://git.kernel.org/mkp/scsi/c/7dfdcc393dcd

--
Martin K. Petersen Oracle Linux Engineering