2020-04-26 15:46:30

by Bo YU

Subject: [PATCH -next] include/linux: delete duplicated kernel.h in nodemask.h

In nodemask.h, it includes bitmap.h which has included kernel.h,
so delete kernel.h from nodemask file.

Signed-off-by: Bo YU <[email protected]>
---
BTW, I do not get maintainer of the get_maintainer file, so i do
not know who can accept the patch if it is right.
---
include/linux/nodemask.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h
index 27e7fa36f707..980b48e05d05 100644
--- a/include/linux/nodemask.h
+++ b/include/linux/nodemask.h
@@ -46,7 +46,7 @@
* int next_node(node, mask) Next node past 'node', or MAX_NUMNODES
* int next_node_in(node, mask) Next node past 'node', or wrap to first,
* or MAX_NUMNODES
- * int first_unset_node(mask) First node not set in mask, or
+ * int first_unset_node(mask) First node not set in mask, or
* MAX_NUMNODES
*
* nodemask_t nodemask_of_node(node) Return nodemask with bit 'node' set
@@ -90,7 +90,6 @@
* for such situations. See below and CPUMASK_ALLOC also.
*/

-#include <linux/kernel.h>
#include <linux/threads.h>
#include <linux/bitmap.h>
#include <linux/numa.h>
--
2.11.0

2020-04-26 17:12:31

by Greg Kroah-Hartman

Subject: Re: [PATCH -next] include/linux: delete duplicated kernel.h in nodemask.h

On Sun, Apr 26, 2020 at 11:42:35PM +0800, Bo YU wrote:
> In nodemask.h, it includes bitmap.h which has included kernel.h,
> so delete kernel.h from nodemask file.
>
> Signed-off-by: Bo YU <[email protected]>
> ---
> BTW, I do not get maintainer of the get_maintainer file, so i do
> not know who can accept the patch if it is right.
> ---
> include/linux/nodemask.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h
> index 27e7fa36f707..980b48e05d05 100644
> --- a/include/linux/nodemask.h
> +++ b/include/linux/nodemask.h
> @@ -46,7 +46,7 @@
> * int next_node(node, mask) Next node past 'node', or MAX_NUMNODES
> * int next_node_in(node, mask) Next node past 'node', or wrap to first,
> * or MAX_NUMNODES
> - * int first_unset_node(mask) First node not set in mask, or
> + * int first_unset_node(mask) First node not set in mask, or
> * MAX_NUMNODES
> *
> * nodemask_t nodemask_of_node(node) Return nodemask with bit 'node' set

That change is not described above :(

2020-04-27 00:35:02

by Bo YU

Subject: Re: [PATCH -next] include/linux: delete duplicated kernel.h in nodemask.h

On Sun, Apr 26, 2020 at 07:09:42PM +0200, Greg KH wrote:
>On Sun, Apr 26, 2020 at 11:42:35PM +0800, Bo YU wrote:
>> In nodemask.h, it includes bitmap.h which has included kernel.h,
>> so delete kernel.h from nodemask file.
>>
>> Signed-off-by: Bo YU <[email protected]>
>> ---
>> BTW, I do not get maintainer of the get_maintainer file, so i do
>> not know who can accept the patch if it is right.
>> ---
>> include/linux/nodemask.h | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h
>> index 27e7fa36f707..980b48e05d05 100644
>> --- a/include/linux/nodemask.h
>> +++ b/include/linux/nodemask.h
>> @@ -46,7 +46,7 @@
>> * int next_node(node, mask) Next node past 'node', or MAX_NUMNODES
>> * int next_node_in(node, mask) Next node past 'node', or wrap to first,
>> * or MAX_NUMNODES
>> - * int first_unset_node(mask) First node not set in mask, or
>> + * int first_unset_node(mask) First node not set in mask, or
>> * MAX_NUMNODES
>> *
>> * nodemask_t nodemask_of_node(node) Return nodemask with bit 'node' set
>
>That change is not described above :(
I promise i just delete kernel.h in the nodemask file. I am wonder why
change the comment also :)
>