2020-04-26 17:03:57

by Matheus Castello

Subject: [PATCH v4 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador

Update the documentation to add the Caninos Loucos Labrador. Labrador
project consists of a computer on module based on the Actions Semi S500
processor and the Labrador base board.

Signed-off-by: Matheus Castello <[email protected]>
Acked-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/arm/actions.yaml | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
index ace3fdaa8396..50dd976128dc 100644
--- a/Documentation/devicetree/bindings/arm/actions.yaml
+++ b/Documentation/devicetree/bindings/arm/actions.yaml
@@ -21,9 +21,14 @@ properties:
- const: actions,s500
- items:
- enum:
- - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B
- - const: lemaker,guitar
- - const: actions,s500
+ - caninos,labrador-v2 # Labrador Core v2
+ - caninos,labrador-base-m # Labrador Base Board M v1
+ - const: actions,s500
+ - items:
+ - enum:
+ - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B
+ - const: lemaker,guitar
+ - const: actions,s500

# The Actions Semi S700 is a quad-core ARM Cortex-A53 SoC.
- items:
--
2.25.0

2020-04-27 21:34:34

by Rob Herring

Subject: Re: [PATCH v4 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador

On Sun, 26 Apr 2020 13:58:34 -0300, Matheus Castello wrote:
> Update the documentation to add the Caninos Loucos Labrador. Labrador
> project consists of a computer on module based on the Actions Semi S500
> processor and the Labrador base board.
>
> Signed-off-by: Matheus Castello <[email protected]>
> Acked-by: Rob Herring <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/actions.yaml | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>

My bot found errors running 'make dt_binding_check' on your patch:

Documentation/devicetree/bindings/arm/actions.yaml: while scanning for the next token
found character that cannot start any token
in "<unicode string>", line 24, column 1
Documentation/devicetree/bindings/Makefile:11: recipe for target 'Documentation/devicetree/bindings/arm/actions.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/arm/actions.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
warning: no schema found in file: Documentation/devicetree/bindings/arm/actions.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/actions.yaml: ignoring, error parsing file
warning: no schema found in file: Documentation/devicetree/bindings/arm/actions.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/actions.yaml: ignoring, error parsing file
Makefile:1300: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1277145

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.