Hi all,
In commit
a66d0af81726 ("i2c: iproc: generate stop event for slave writes")
Fixes tag
Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode")
has these problem(s):
- No SHA1 recognised
This triggered because the "space" after the ":" is a Unicode non-breaking
space (U+0x00a0, UTF8 0xc2 0xa0). I am not sure if this is a problem
or not. This is the forst time I have seen this.
--
Cheers,
Stephen Rothwell
> This triggered because the "space" after the ":" is a Unicode non-breaking
> space (U+0x00a0, UTF8 0xc2 0xa0). I am not sure if this is a problem
> or not. This is the forst time I have seen this.
Thanks for reporting, I obviously didn't notice. Well, technically,
commit messages can be UTF8, so not really an error. However, it will
probably break lots of homebrew scripts, so a checkpatch warning it is,
then?
I'll fix it nonetheless.
Hi Wolfram,
On Tue, 28 Apr 2020 09:01:30 +0200 Wolfram Sang <[email protected]> wrote:
>
> > This triggered because the "space" after the ":" is a Unicode non-breaking
> > space (U+0x00a0, UTF8 0xc2 0xa0). I am not sure if this is a problem
> > or not. This is the forst time I have seen this.
>
> Thanks for reporting, I obviously didn't notice. Well, technically,
> commit messages can be UTF8, so not really an error. However, it will
> probably break lots of homebrew scripts, so a checkpatch warning it is,
> then?
Not checkpatch, but my own script that checks some things about Fixes
tags (attached). Interestingly, my script does allow some other Unicode
things (like matching quotes) ...
> I'll fix it nonetheless.
Thanks.
--
Cheers,
Stephen Rothwell
> > Thanks for reporting, I obviously didn't notice. Well, technically,
> > commit messages can be UTF8, so not really an error. However, it will
> > probably break lots of homebrew scripts, so a checkpatch warning it is,
> > then?
>
> Not checkpatch, but my own script that checks some things about Fixes
> tags (attached). Interestingly, my script does allow some other Unicode
> things (like matching quotes) ...
I wondered if it makes sense to add a warning to checkpatch; but on
second thought, the tags may include UTF8 anyhow for proper author
names. So, maybe we should be generous in what we accept and simply
update our tooling?