2020-04-29 10:47:25

by Sergiu Cuciurean

Subject: [PATCH] iio: adc: ad7768-1: Fix channel endian spec

This change removes the endian description from the iio channel spec.
In this way, the default (IIO_CPU) endian will be used, matching the
be32_to_cpu() conversion from ad7768_spi_reg_read().

Fixes: 8a15c73a9bcfe ("iio: adc: Add AD7768-1 ADC basic support")

Signed-off-by: Sergiu Cuciurean <[email protected]>
---
drivers/iio/adc/ad7768-1.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
index a0027797a7fe..99da13c3511a 100644
--- a/drivers/iio/adc/ad7768-1.c
+++ b/drivers/iio/adc/ad7768-1.c
@@ -144,7 +144,6 @@ static const struct iio_chan_spec ad7768_channels[] = {
.realbits = 24,
.storagebits = 32,
.shift = 8,
- .endianness = IIO_BE,
},
},
};
--
2.17.1

2020-05-03 11:43:57

by Jonathan Cameron

Subject: Re: [PATCH] iio: adc: ad7768-1: Fix channel endian spec

On Wed, 29 Apr 2020 13:45:35 +0300
Sergiu Cuciurean <[email protected]> wrote:

> This change removes the endian description from the iio channel spec.
> In this way, the default (IIO_CPU) endian will be used, matching the
> be32_to_cpu() conversion from ad7768_spi_reg_read().
>
> Fixes: 8a15c73a9bcfe ("iio: adc: Add AD7768-1 ADC basic support")
>
> Signed-off-by: Sergiu Cuciurean <[email protected]>

Hi Sergiu,

The endian marking only applies to the push_to_buffers data. That
is read from the hardware using spi_read, not the ad7768_spi_reg_read
function. So logic above doesn't hold.

Thanks,

Jonathan

> ---
> drivers/iio/adc/ad7768-1.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
> index a0027797a7fe..99da13c3511a 100644
> --- a/drivers/iio/adc/ad7768-1.c
> +++ b/drivers/iio/adc/ad7768-1.c
> @@ -144,7 +144,6 @@ static const struct iio_chan_spec ad7768_channels[] = {
> .realbits = 24,
> .storagebits = 32,
> .shift = 8,
> - .endianness = IIO_BE,
> },
> },
> };