2020-04-30 12:20:43

by Jason Yan

Subject: [PATCH] scsi: vmw_pvscsi: use true,false for adapter->use_msg

Fix the following coccicheck warning:

drivers/scsi/vmw_pvscsi.c:911:2-18: WARNING: Assignment of 0/1 to bool
variable

Signed-off-by: Jason Yan <[email protected]>
---
drivers/scsi/vmw_pvscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index c3f010df641e..8dbb4db6831a 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -908,7 +908,7 @@ static int pvscsi_host_reset(struct scsi_cmnd *cmd)
use_msg = adapter->use_msg;

if (use_msg) {
- adapter->use_msg = 0;
+ adapter->use_msg = false;
spin_unlock_irqrestore(&adapter->hw_lock, flags);

/*
--
2.21.1

2020-05-08 02:58:59

by Martin K. Petersen

Subject: Re: [PATCH] scsi: vmw_pvscsi: use true,false for adapter->use_msg

On Thu, 30 Apr 2020 20:17:29 +0800, Jason Yan wrote:

> Fix the following coccicheck warning:
>
> drivers/scsi/vmw_pvscsi.c:911:2-18: WARNING: Assignment of 0/1 to bool
> variable

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: vmw_pvscsi: Use true, false for adapter->use_msg
https://git.kernel.org/mkp/scsi/c/013f69a931e7

--
Martin K. Petersen Oracle Linux Engineering