2020-04-26 09:46:03

by Jason Yan

[permalink] [raw]
Subject: [PATCH] i2c: powermac: use true,false for bool variable

In i2c_powermac_register_devices(), variable 'found_onyx' is bool and
assigned '0' and 'true' in different places. Use 'false' instead of '0'.
This fixes the following coccicheck warning:

drivers/i2c/busses/i2c-powermac.c:318:6-16: WARNING: Assignment of 0/1
to bool variable

Signed-off-by: Jason Yan <[email protected]>
---
drivers/i2c/busses/i2c-powermac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c
index d565714c1f13..00a6fd42c1ae 100644
--- a/drivers/i2c/busses/i2c-powermac.c
+++ b/drivers/i2c/busses/i2c-powermac.c
@@ -315,7 +315,7 @@ static void i2c_powermac_register_devices(struct i2c_adapter *adap,
{
struct i2c_client *newdev;
struct device_node *node;
- bool found_onyx = 0;
+ bool found_onyx = false;

/*
* In some cases we end up with the via-pmu node itself, in this
--
2.21.1


2020-04-30 14:22:47

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: powermac: use true,false for bool variable

On Sun, Apr 26, 2020 at 05:42:28PM +0800, Jason Yan wrote:
> In i2c_powermac_register_devices(), variable 'found_onyx' is bool and
> assigned '0' and 'true' in different places. Use 'false' instead of '0'.
> This fixes the following coccicheck warning:
>
> drivers/i2c/busses/i2c-powermac.c:318:6-16: WARNING: Assignment of 0/1
> to bool variable
>
> Signed-off-by: Jason Yan <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (443.00 B)
signature.asc (849.00 B)
Download all attachments