2020-05-05 07:50:43

by Jason Yan

Subject: [PATCH net-next] net: atheros: remove conversion to bool in atl1c_start_mac()

No need to convert '==' expression to bool. This fixes the following
coccicheck warning:

drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1189:63-68: WARNING:
conversion to bool not needed here

Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 00bd7bd55794..04bc53af12d9 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -1186,7 +1186,7 @@ static void atl1c_start_mac(struct atl1c_adapter *adapter)
struct atl1c_hw *hw = &adapter->hw;
u32 mac, txq, rxq;

- hw->mac_duplex = adapter->link_duplex == FULL_DUPLEX ? true : false;
+ hw->mac_duplex = adapter->link_duplex == FULL_DUPLEX;
hw->mac_speed = adapter->link_speed == SPEED_1000 ?
atl1c_mac_speed_1000 : atl1c_mac_speed_10_100;

--
2.21.1

2020-05-05 18:42:55

by David Miller

Subject: Re: [PATCH net-next] net: atheros: remove conversion to bool in atl1c_start_mac()

From: Jason Yan <[email protected]>
Date: Tue, 5 May 2020 15:45:46 +0800

> No need to convert '==' expression to bool. This fixes the following
> coccicheck warning:
>
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1189:63-68: WARNING:
> conversion to bool not needed here
>
> Signed-off-by: Jason Yan <[email protected]>

Applied.