2020-05-05 07:51:56

by Jason Yan

Subject: [PATCH net-next] net: ethernet: ti: use true,false for bool variables in cpsw_new.c

Fix the following coccicheck warning:

drivers/net/ethernet/ti/cpsw_new.c:1924:2-17: WARNING: Assignment of
0/1 to bool variable
drivers/net/ethernet/ti/cpsw_new.c:1231:1-16: WARNING: Assignment of
0/1 to bool variable

Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/ethernet/ti/cpsw_new.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c
index 33c8dd686206..dce49311d3d3 100644
--- a/drivers/net/ethernet/ti/cpsw_new.c
+++ b/drivers/net/ethernet/ti/cpsw_new.c
@@ -1228,7 +1228,7 @@ static int cpsw_probe_dt(struct cpsw_common *cpsw)
data->active_slave = 0;
data->channels = CPSW_MAX_QUEUES;
data->ale_entries = CPSW_ALE_NUM_ENTRIES;
- data->dual_emac = 1;
+ data->dual_emac = true;
data->bd_ram_size = CPSW_BD_RAM_SIZE;
data->mac_control = 0;

@@ -1921,7 +1921,7 @@ static int cpsw_probe(struct platform_device *pdev)

soc = soc_device_match(cpsw_soc_devices);
if (soc)
- cpsw->quirk_irq = 1;
+ cpsw->quirk_irq = true;

cpsw->rx_packet_max = rx_packet_max;
cpsw->descs_pool_size = descs_pool_size;
--
2.21.1

2020-05-05 18:43:59

by David Miller

Subject: Re: [PATCH net-next] net: ethernet: ti: use true,false for bool variables in cpsw_new.c

From: Jason Yan <[email protected]>
Date: Tue, 5 May 2020 15:46:23 +0800

> Fix the following coccicheck warning:
>
> drivers/net/ethernet/ti/cpsw_new.c:1924:2-17: WARNING: Assignment of
> 0/1 to bool variable
> drivers/net/ethernet/ti/cpsw_new.c:1231:1-16: WARNING: Assignment of
> 0/1 to bool variable
>
> Signed-off-by: Jason Yan <[email protected]>

Applied.