2020-05-05 08:51:22

by Yue Haibing

Subject: [PATCH net-next] net: sched: choke: Remove unused inline function choke_set_classid

There's no callers in-tree anymore since commit 5952fde10c35 ("net:
sched: choke: remove dead filter classify code")

Signed-off-by: YueHaibing <[email protected]>
---
net/sched/sch_choke.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/net/sched/sch_choke.c b/net/sched/sch_choke.c
index a36974e9c601..2d350c734375 100644
--- a/net/sched/sch_choke.c
+++ b/net/sched/sch_choke.c
@@ -142,11 +142,6 @@ static inline struct choke_skb_cb *choke_skb_cb(const struct sk_buff *skb)
return (struct choke_skb_cb *)qdisc_skb_cb(skb)->data;
}

-static inline void choke_set_classid(struct sk_buff *skb, u16 classid)
-{
- choke_skb_cb(skb)->classid = classid;
-}
-
/*
* Compare flow of two packets
* Returns true only if source and destination address and port match.
--
2.17.1

2020-05-05 18:24:54

by Cong Wang

Subject: Re: [PATCH net-next] net: sched: choke: Remove unused inline function choke_set_classid

On Tue, May 5, 2020 at 1:49 AM YueHaibing <[email protected]> wrote:
>
> There's no callers in-tree anymore since commit 5952fde10c35 ("net:
> sched: choke: remove dead filter classify code")

While you are at this, please also remove classid from
struct choke_skb_cb.

Thanks.

2020-05-05 19:49:16

by David Miller

Subject: Re: [PATCH net-next] net: sched: choke: Remove unused inline function choke_set_classid

From: YueHaibing <[email protected]>
Date: Tue, 5 May 2020 16:47:36 +0800

> There's no callers in-tree anymore since commit 5952fde10c35 ("net:
> sched: choke: remove dead filter classify code")
>
> Signed-off-by: YueHaibing <[email protected]>

Applied.