2020-05-05 07:41:21

by Jason Yan

Subject: [PATCH] scsi: bfa: make bfad_iocmd_ioc_get_stats() static

Fix the following sparse warning:

drivers/scsi/bfa/bfad_bsg.c:140:1: warning: symbol
'bfad_iocmd_ioc_get_stats' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/scsi/bfa/bfad_bsg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
index a76c968dbac5..412dbe125e10 100644
--- a/drivers/scsi/bfa/bfad_bsg.c
+++ b/drivers/scsi/bfa/bfad_bsg.c
@@ -136,7 +136,7 @@ bfad_iocmd_ioc_get_attr(struct bfad_s *bfad, void *cmd)
return 0;
}

-int
+static int
bfad_iocmd_ioc_get_stats(struct bfad_s *bfad, void *cmd)
{
struct bfa_bsg_ioc_stats_s *iocmd = (struct bfa_bsg_ioc_stats_s *)cmd;
--
2.21.1

2020-05-12 03:31:41

by Martin K. Petersen

Subject: Re: [PATCH] scsi: bfa: make bfad_iocmd_ioc_get_stats() static

On Tue, 5 May 2020 15:38:07 +0800, Jason Yan wrote:

> Fix the following sparse warning:
>
> drivers/scsi/bfa/bfad_bsg.c:140:1: warning: symbol
> 'bfad_iocmd_ioc_get_stats' was not declared. Should it be static?

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: bfa: Make bfad_iocmd_ioc_get_stats() static
https://git.kernel.org/mkp/scsi/c/102026483d2b

--
Martin K. Petersen Oracle Linux Engineering