2020-05-05 07:50:38

by Jason Yan

Subject: [PATCH net-next] net: qede: Use true for bool variable in qede_init_fp()

Fix the following coccicheck warning:

drivers/net/ethernet/qlogic/qede/qede_main.c:1717:5-19: WARNING:
Assignment of 0/1 to bool variable

Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index 9b456198cb50..256506024b88 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -1714,7 +1714,7 @@ static void qede_init_fp(struct qede_dev *edev)
txq->ndev_txq_id = ndev_tx_id;

if (edev->dev_info.is_legacy)
- txq->is_legacy = 1;
+ txq->is_legacy = true;
txq->dev = &edev->pdev->dev;
}

--
2.21.1

2020-05-05 18:44:40

by David Miller

Subject: Re: [PATCH net-next] net: qede: Use true for bool variable in qede_init_fp()

From: Jason Yan <[email protected]>
Date: Tue, 5 May 2020 15:45:39 +0800

> Fix the following coccicheck warning:
>
> drivers/net/ethernet/qlogic/qede/qede_main.c:1717:5-19: WARNING:
> Assignment of 0/1 to bool variable
>
> Signed-off-by: Jason Yan <[email protected]>

Applied.