2020-05-06 10:44:50

by Jason Yan

Subject: [PATCH net-next] net: bridge: return false in br_mrp_enabled()

Fix the following coccicheck warning:

net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function
'br_mrp_enabled' with return type bool

Signed-off-by: Jason Yan <[email protected]>
---
net/bridge/br_private.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index c35647cb138a..78d3a951180d 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -1331,7 +1331,7 @@ static inline int br_mrp_process(struct net_bridge_port *p, struct sk_buff *skb)

static inline bool br_mrp_enabled(struct net_bridge *br)
{
- return 0;
+ return false;
}

static inline void br_mrp_port_del(struct net_bridge *br,
--
2.21.1

2020-05-06 21:00:29

by David Miller

Subject: Re: [PATCH net-next] net: bridge: return false in br_mrp_enabled()

From: Jason Yan <[email protected]>
Date: Wed, 6 May 2020 14:16:16 +0800

> Fix the following coccicheck warning:
>
> net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function
> 'br_mrp_enabled' with return type bool
>
> Signed-off-by: Jason Yan <[email protected]>

Applied.