2020-05-06 10:47:59

by Zou Wei

Subject: [PATCH -next] net: ethernet: mediatek: Make mtk_m32 static

Fix the following sparse warning:

drivers/net/ethernet/mediatek/mtk_eth_soc.c:68:5: warning:
symbol 'mtk_m32' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Samuel Zou <[email protected]>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 0904710..2822268 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -65,7 +65,7 @@ u32 mtk_r32(struct mtk_eth *eth, unsigned reg)
return __raw_readl(eth->base + reg);
}

-u32 mtk_m32(struct mtk_eth *eth, u32 mask, u32 set, unsigned reg)
+static u32 mtk_m32(struct mtk_eth *eth, u32 mask, u32 set, unsigned reg)
{
u32 val;

--
2.6.2

2020-05-06 21:06:49

by David Miller

Subject: Re: [PATCH -next] net: ethernet: mediatek: Make mtk_m32 static

From: Samuel Zou <[email protected]>
Date: Wed, 6 May 2020 14:27:30 +0800

> Fix the following sparse warning:
>
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:68:5: warning:
> symbol 'mtk_m32' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Samuel Zou <[email protected]>

Applied, thanks.