2020-05-06 11:28:40

by Chen Tao

Subject: [PATCH -next] net: enetc: Make some symbols static

Fix the following warning:

drivers/net/ethernet/freescale/enetc/enetc_qos.c:427:20: warning:
symbol 'enetc_act_fwd' was not declared. Should it be static?
drivers/net/ethernet/freescale/enetc/enetc_qos.c:966:20: warning:
symbol 'enetc_check_flow_actions' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: ChenTao <[email protected]>
---
drivers/net/ethernet/freescale/enetc/enetc_qos.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
index 48e589e9d0f7..172acb602ccb 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
@@ -424,7 +424,7 @@ struct enetc_psfp {
spinlock_t psfp_lock; /* spinlock for the struct enetc_psfp r/w */
};

-struct actions_fwd enetc_act_fwd[] = {
+static struct actions_fwd enetc_act_fwd[] = {
{
BIT(FLOW_ACTION_GATE),
BIT(FLOW_DISSECTOR_KEY_ETH_ADDRS),
@@ -963,7 +963,8 @@ static int enetc_psfp_hw_set(struct enetc_ndev_priv *priv,
return err;
}

-struct actions_fwd *enetc_check_flow_actions(u64 acts, unsigned int inputkeys)
+static struct actions_fwd *enetc_check_flow_actions(u64 acts,
+ unsigned int inputkeys)
{
int i;

--
2.22.0

2020-05-06 21:24:28

by David Miller

Subject: Re: [PATCH -next] net: enetc: Make some symbols static

From: ChenTao <[email protected]>
Date: Wed, 6 May 2020 19:22:17 +0800

> Fix the following warning:
>
> drivers/net/ethernet/freescale/enetc/enetc_qos.c:427:20: warning:
> symbol 'enetc_act_fwd' was not declared. Should it be static?
> drivers/net/ethernet/freescale/enetc/enetc_qos.c:966:20: warning:
> symbol 'enetc_check_flow_actions' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: ChenTao <[email protected]>

Applied.