2020-05-06 06:19:49

by Jason Yan

Subject: [PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_get_rxfh()

Fix the following coccicheck warning:

drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1238:5-8: Unneeded
variable: "err". Return "0" on line 1252

Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
index 8a5ea2543670..216e6b2e9eed 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
@@ -1235,7 +1235,6 @@ static int mlx4_en_get_rxfh(struct net_device *dev, u32 *ring_index, u8 *key,
struct mlx4_en_priv *priv = netdev_priv(dev);
u32 n = mlx4_en_get_rxfh_indir_size(dev);
u32 i, rss_rings;
- int err = 0;

rss_rings = priv->prof->rss_rings ?: n;
rss_rings = rounddown_pow_of_two(rss_rings);
@@ -1249,7 +1248,7 @@ static int mlx4_en_get_rxfh(struct net_device *dev, u32 *ring_index, u8 *key,
memcpy(key, priv->rss_key, MLX4_EN_RSS_KEY_SIZE);
if (hfunc)
*hfunc = priv->rss_hash_fn;
- return err;
+ return 0;
}

static int mlx4_en_set_rxfh(struct net_device *dev, const u32 *ring_index,
--
2.21.1

2020-05-06 21:01:27

by David Miller

Subject: Re: [PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_get_rxfh()

From: Jason Yan <[email protected]>
Date: Wed, 6 May 2020 14:16:30 +0800

> Fix the following coccicheck warning:
>
> drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1238:5-8: Unneeded
> variable: "err". Return "0" on line 1252
>
> Signed-off-by: Jason Yan <[email protected]>

Applied.