2020-05-06 10:45:35

by Jason Yan

Subject: [PATCH] ALSA: hda: Return true,false for return type bool

Fix the following coccicheck warning:

include/sound/hdaudio.h:210:73-74: WARNING: return of 0/1 in function
'snd_hdac_is_in_pm' with return type bool
include/sound/hdaudio.h:211:76-77: WARNING: return of 0/1 in function
'snd_hdac_is_power_on' with return type bool

Signed-off-by: Jason Yan <[email protected]>
---
include/sound/hdaudio.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
index d365297b3698..10945963d727 100644
--- a/include/sound/hdaudio.h
+++ b/include/sound/hdaudio.h
@@ -207,8 +207,8 @@ static inline int snd_hdac_power_down_pm(struct hdac_device *codec) { return 0;
static inline int snd_hdac_keep_power_up(struct hdac_device *codec) { return 0; }
static inline void snd_hdac_enter_pm(struct hdac_device *codec) {}
static inline void snd_hdac_leave_pm(struct hdac_device *codec) {}
-static inline bool snd_hdac_is_in_pm(struct hdac_device *codec) { return 0; }
-static inline bool snd_hdac_is_power_on(struct hdac_device *codec) { return 1; }
+static inline bool snd_hdac_is_in_pm(struct hdac_device *codec) { return false; }
+static inline bool snd_hdac_is_power_on(struct hdac_device *codec) { return true; }
#endif

/*
--
2.21.1

2020-05-06 10:49:05

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda: Return true,false for return type bool

On Wed, 06 May 2020 08:17:16 +0200,
Jason Yan wrote:
>
> Fix the following coccicheck warning:
>
> include/sound/hdaudio.h:210:73-74: WARNING: return of 0/1 in function
> 'snd_hdac_is_in_pm' with return type bool
> include/sound/hdaudio.h:211:76-77: WARNING: return of 0/1 in function
> 'snd_hdac_is_power_on' with return type bool
>
> Signed-off-by: Jason Yan <[email protected]>

Thanks, applied.


Takashi