2020-05-06 06:21:33

by Jason Yan

Subject: [PATCH] scsi: qla2xxx: make qlafx00_process_aen() return void

No other functions use the return value of qlafx00_process_aen() and the
return value is always 0 now. Make it return void. This fixes the
following coccicheck warning:

drivers/scsi/qla2xxx/qla_mr.c:1716:5-9: Unneeded variable: "rval".
Return "0" on line 1768

Signed-off-by: Jason Yan <[email protected]>
---
drivers/scsi/qla2xxx/qla_gbl.h | 2 +-
drivers/scsi/qla2xxx/qla_mr.c | 5 +----
2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_gbl.h b/drivers/scsi/qla2xxx/qla_gbl.h
index b20c5fa122fb..f62b71e47581 100644
--- a/drivers/scsi/qla2xxx/qla_gbl.h
+++ b/drivers/scsi/qla2xxx/qla_gbl.h
@@ -771,7 +771,7 @@ extern int qlafx00_fw_ready(scsi_qla_host_t *);
extern int qlafx00_configure_devices(scsi_qla_host_t *);
extern int qlafx00_reset_initialize(scsi_qla_host_t *);
extern int qlafx00_fx_disc(scsi_qla_host_t *, fc_port_t *, uint16_t);
-extern int qlafx00_process_aen(struct scsi_qla_host *, struct qla_work_evt *);
+extern void qlafx00_process_aen(struct scsi_qla_host *, struct qla_work_evt *);
extern int qlafx00_post_aenfx_work(struct scsi_qla_host *, uint32_t,
uint32_t *, int);
extern uint32_t qlafx00_fw_state_show(struct device *,
diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c
index df99911b8bb9..ce98189c7872 100644
--- a/drivers/scsi/qla2xxx/qla_mr.c
+++ b/drivers/scsi/qla2xxx/qla_mr.c
@@ -1710,10 +1710,9 @@ qlafx00_tgt_detach(struct scsi_qla_host *vha, int tgt_id)
return;
}

-int
+void
qlafx00_process_aen(struct scsi_qla_host *vha, struct qla_work_evt *evt)
{
- int rval = 0;
uint32_t aen_code, aen_data;

aen_code = FCH_EVT_VENDOR_UNIQUE;
@@ -1764,8 +1763,6 @@ qlafx00_process_aen(struct scsi_qla_host *vha, struct qla_work_evt *evt)

fc_host_post_event(vha->host, fc_get_event_number(),
aen_code, aen_data);
-
- return rval;
}

static void
--
2.21.1

2020-05-06 15:47:38

by Bart Van Assche

Subject: Re: [PATCH] scsi: qla2xxx: make qlafx00_process_aen() return void

On 2020-05-05 23:17, Jason Yan wrote:
> No other functions use the return value of qlafx00_process_aen() and the
> return value is always 0 now. Make it return void. This fixes the
> following coccicheck warning:
>
> drivers/scsi/qla2xxx/qla_mr.c:1716:5-9: Unneeded variable: "rval".
> Return "0" on line 1768

Reviewed-by: Bart Van Assche <[email protected]>

2020-05-08 03:00:09

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qla2xxx: make qlafx00_process_aen() return void

On Wed, 6 May 2020 14:17:57 +0800, Jason Yan wrote:

> No other functions use the return value of qlafx00_process_aen() and the
> return value is always 0 now. Make it return void. This fixes the
> following coccicheck warning:
>
> drivers/scsi/qla2xxx/qla_mr.c:1716:5-9: Unneeded variable: "rval".
> Return "0" on line 1768

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: qla2xxx: Make qlafx00_process_aen() return void
https://git.kernel.org/mkp/scsi/c/88bfdf565cbe

--
Martin K. Petersen Oracle Linux Engineering