2020-05-06 10:45:59

by Jason Yan

Subject: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata()

Fix the following coccicheck warning:

arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return
"0" on line 161

Signed-off-by: Jason Yan <[email protected]>
---
arch/arm/mach-omap2/dma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
index 8cc109cc242a..ef5022bc91a2 100644
--- a/arch/arm/mach-omap2/dma.c
+++ b/arch/arm/mach-omap2/dma.c
@@ -79,8 +79,6 @@ static const struct omap_dma_reg reg_map[] = {

static unsigned configure_dma_errata(void)
{
- unsigned errata = 0;
-
/*
* Errata applicable for OMAP2430ES1.0 and all omap2420
*
@@ -158,7 +156,7 @@ static unsigned configure_dma_errata(void)
if (cpu_is_omap34xx() && (omap_type() != OMAP2_DEVICE_TYPE_GP))
SET_DMA_ERRATA(DMA_ROMCODE_BUG);

- return errata;
+ return 0;
}

static const struct dma_slave_map omap24xx_sdma_dt_map[] = {
--
2.21.1

2020-05-06 11:04:43

by Russell King (Oracle)

Subject: Re: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata()

On Wed, May 06, 2020 at 02:19:00PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return
> "0" on line 161

NAK. Look closer at what the code is doing, thanks.

This warning is basically incorrect.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up