2020-05-06 06:23:46

by Jason Yan

Subject: [PATCH] dma-buf: heaps: Remove Unneeded variable "ret" in dma_heap_dma_buf_begin_cpu_access()

Fix the following coccicheck warning:

drivers/dma-buf/heaps/heap-helpers.c:203:5-8: Unneeded variable: "ret".
Return "0" on line 216

Signed-off-by: Jason Yan <[email protected]>
---
drivers/dma-buf/heaps/heap-helpers.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma-buf/heaps/heap-helpers.c b/drivers/dma-buf/heaps/heap-helpers.c
index 9f964ca3f59c..c82872501ba2 100644
--- a/drivers/dma-buf/heaps/heap-helpers.c
+++ b/drivers/dma-buf/heaps/heap-helpers.c
@@ -200,7 +200,6 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,
{
struct heap_helper_buffer *buffer = dmabuf->priv;
struct dma_heaps_attachment *a;
- int ret = 0;

mutex_lock(&buffer->lock);

@@ -213,7 +212,7 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,
}
mutex_unlock(&buffer->lock);

- return ret;
+ return 0;
}

static int dma_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf,
--
2.21.1

2020-05-06 09:16:18

by Brian Starkey

Subject: Re: [PATCH] dma-buf: heaps: Remove Unneeded variable "ret" in dma_heap_dma_buf_begin_cpu_access()

Hi Jason,

On Wed, May 06, 2020 at 02:18:51PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/dma-buf/heaps/heap-helpers.c:203:5-8: Unneeded variable: "ret".
> Return "0" on line 216
>
> Signed-off-by: Jason Yan <[email protected]>

LGTM.

Reviewed-by: Brian Starkey <[email protected]>

Thanks,
-Brian

> ---
> drivers/dma-buf/heaps/heap-helpers.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/heaps/heap-helpers.c b/drivers/dma-buf/heaps/heap-helpers.c
> index 9f964ca3f59c..c82872501ba2 100644
> --- a/drivers/dma-buf/heaps/heap-helpers.c
> +++ b/drivers/dma-buf/heaps/heap-helpers.c
> @@ -200,7 +200,6 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,
> {
> struct heap_helper_buffer *buffer = dmabuf->priv;
> struct dma_heaps_attachment *a;
> - int ret = 0;
>
> mutex_lock(&buffer->lock);
>
> @@ -213,7 +212,7 @@ static int dma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,
> }
> mutex_unlock(&buffer->lock);
>
> - return ret;
> + return 0;
> }
>
> static int dma_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf,
> --
> 2.21.1
>