2020-05-06 11:49:06

by Chen Tao

[permalink] [raw]
Subject: [PATCH -next] power/supply/cw2015: Make some symbols static

Fix the following warning:

drivers/power/supply/cw2015_battery.c:96:5: warning:
'cw_update_profile' was not declared. Should it be static?
drivers/power/supply/cw2015_battery.c:712:1: warning:
'cw_bat_pm_ops' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: ChenTao <[email protected]>
---
drivers/power/supply/cw2015_battery.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/power/supply/cw2015_battery.c b/drivers/power/supply/cw2015_battery.c
index 8603da6f4593..19f62ea957ee 100644
--- a/drivers/power/supply/cw2015_battery.c
+++ b/drivers/power/supply/cw2015_battery.c
@@ -93,7 +93,7 @@ static int cw_read_word(struct cw_battery *cw_bat, u8 reg, u16 *val)
return 0;
}

-int cw_update_profile(struct cw_battery *cw_bat)
+static int cw_update_profile(struct cw_battery *cw_bat)
{
int ret;
unsigned int reg_val;
@@ -709,7 +709,7 @@ static int __maybe_unused cw_bat_resume(struct device *dev)
return 0;
}

-SIMPLE_DEV_PM_OPS(cw_bat_pm_ops, cw_bat_suspend, cw_bat_resume);
+static SIMPLE_DEV_PM_OPS(cw_bat_pm_ops, cw_bat_suspend, cw_bat_resume);

static int cw_bat_remove(struct i2c_client *client)
{
--
2.22.0


2020-05-06 20:16:23

by Tobias Schramm

[permalink] [raw]
Subject: Re: [PATCH -next] power/supply/cw2015: Make some symbols static


> Fix the following warning:
>
> drivers/power/supply/cw2015_battery.c:96:5: warning:
> 'cw_update_profile' was not declared. Should it be static?
> drivers/power/supply/cw2015_battery.c:712:1: warning:
> 'cw_bat_pm_ops' was not declared. Should it be static?
>

LGTM.

Acked-by: Tobias Schramm <[email protected]>
Tested-by: Tobias Schramm <[email protected]>

Thanks,

Tobias

2020-05-09 00:17:15

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH -next] power/supply/cw2015: Make some symbols static

Hi,

On Wed, May 06, 2020 at 09:49:26PM +0200, Tobias Schramm wrote:
> > Fix the following warning:
> >
> > drivers/power/supply/cw2015_battery.c:96:5: warning:
> > 'cw_update_profile' was not declared. Should it be static?
> > drivers/power/supply/cw2015_battery.c:712:1: warning:
> > 'cw_bat_pm_ops' was not declared. Should it be static?
> >
>
> LGTM.
>
> Acked-by: Tobias Schramm <[email protected]>
> Tested-by: Tobias Schramm <[email protected]>

Thanks, queued.

-- Sebastian

Attachments:
(No filename) (514.00 B)
 signature.asc (849.00 B)
 Download all attachments